Closed Bug 1050654 Opened 5 years ago Closed 5 years ago

Use "flex: none" shorthand in webconsole.inc.css

Categories

(DevTools :: Console, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 34

People

(Reporter: dholbert, Assigned: dholbert)

References

()

Details

Attachments

(1 file)

The file browser/themes/shared/devtools/webconsole.inc.css has several lines like...
  flex: 0 0 auto;
...which bug 1032922 is renaming to...
  flex: 0 0 main-size;
because the "flex-basis:auto" keyword has been renamed to "main-size" in the spec.

These lines should really be using the "flex:none" keyword, because it's...
 (1) more human-readable ("don't flex")
 (2) more concise
 (3) more future-proof, since it's one of the "Common Values of flex" (read as "recommended ways to specify flex") listed at http://dev.w3.org/csswg/css-flexbox/#flex-common

Filing this bug on doing that switch to "flex:none", as suggested in bug 1032922 comment 20.
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Flags: needinfo?(dholbert)
OS: Linux → All
Hardware: x86_64 → All
Comment on attachment 8470411 [details] [diff] [review]
fix: replace "0 0 main-size" with eqiuvalent & more concise "none"

Review of attachment 8470411 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay on this, Daniel. Thanks for the the patch.
Attachment #8470411 - Flags: review?(mihai.sucan) → review+
https://hg.mozilla.org/mozilla-central/rev/cd997ef8a2ad
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
QA Whiteboard: [qa-]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.