1050654 - Use "flex: none" shorthand in webconsole.inc.css

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Daniel Holbert [:dholbert] (PTO until 2/24)]

The file browser/themes/shared/devtools/webconsole.inc.css has several lines like...
  flex: 0 0 auto;
...which bug 1032922 is renaming to...
  flex: 0 0 main-size;
because the "flex-basis:auto" keyword has been renamed to "main-size" in the spec.

These lines should really be using the "flex:none" keyword, because it's...
 (1) more human-readable ("don't flex")
 (2) more concise
 (3) more future-proof, since it's one of the "Common Values of flex" (read as "recommended ways to specify flex") listed at http://dev.w3.org/csswg/css-flexbox/#flex-common

Filing this bug on doing that switch to "flex:none", as suggested in bug 1032922 comment 20.

Comment 1

[Daniel Holbert [:dholbert] (PTO until 2/24)]

Attachment: fix: replace "0 0 main-size" with eqiuvalent & more concise "none"

Comment 2

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 8470411 [details] [diff] [review]
fix: replace "0 0 main-size" with eqiuvalent & more concise "none"

Review of attachment 8470411 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay on this, Daniel. Thanks for the the patch.

Comment 3

[Daniel Holbert [:dholbert] (PTO until 2/24)]

No worries -- thanks for the review!

Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/cd997ef8a2ad

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cd997ef8a2ad