1050679 - [Gaia][Settings] Use network info in state change event instead of read current network info.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Most state change event already contains corresponding network info, and after bug 1050678, we expect have network info in every state change event.
We could use these information while handling state change event to improve user experience.

Comment 1

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: Pull Request

Use wifi network information from event if available.

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8475037 [details] [review]
Pull Request

Chuck, just left some comments on github, please give it a check !

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Chuck, this patch should be landed after bug 1050678, right ? Because currently Gecko is not reflecting with this change, I'll keep the r? on my side and test after that got landed.

WDYK !? :)

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Basically they are good to me :)

Comment 5

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

That's reasonable, thanks!

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8475037 [details] [review]
Pull Request

Sorry for the late reply, Chucklee.

This patch looks ok to me and we just have too add one unit test for _updateNetworkStatus and update nits about indentations.

Thanks !

Comment 7

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Comment on attachment 8475037 [details] [review]
Pull Request

Fix nits and add unit test based existing test case.

Comment 8

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8475037 [details] [review]
Pull Request

Thanks Chucklee ! r+ :)

Comment 9

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/3f3ca2e6f8c2e64e5704d879ed8c7c79e6ce4dbd