Closed Bug 1050679 Opened 8 years ago Closed 8 years ago

[Gaia][Settings] Use network info in state change event instead of read current network info.

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.1 S7 (24Oct)

People

(Reporter: chucklee, Assigned: chucklee)

References

Details

Attachments

(1 file)

Pull Request
46 bytes, text/x-github-pull-request
eragonj
: review+
Details | Review 
Most state change event already contains corresponding network info, and after bug 1050678, we expect have network info in every state change event.
We could use these information while handling state change event to improve user experience.
Attached file Pull Request — 
Use wifi network information from event if available.
Attachment #8475037 - Flags: feedback?(ejchen)
Comment on attachment 8475037 [details] [review]
Pull Request

Chuck, just left some comments on github, please give it a check !
Attachment #8475037 - Flags: feedback?(ejchen)
Chuck, this patch should be landed after bug 1050678, right ? Because currently Gecko is not reflecting with this change, I'll keep the r? on my side and test after that got landed.

WDYK !? :)
Flags: needinfo?(chulee)
Basically they are good to me :)
That's reasonable, thanks!
Flags: needinfo?(chulee)
Comment on attachment 8475037 [details] [review]
Pull Request

Sorry for the late reply, Chucklee.

This patch looks ok to me and we just have too add one unit test for _updateNetworkStatus and update nits about indentations.

Thanks !
Attachment #8475037 - Flags: review?(ejchen)
Comment on attachment 8475037 [details] [review]
Pull Request

Fix nits and add unit test based existing test case.
Attachment #8475037 - Flags: review?(ejchen)
Comment on attachment 8475037 [details] [review]
Pull Request

Thanks Chucklee ! r+ :)
Attachment #8475037 - Flags: review?(ejchen) → review+
https://github.com/mozilla-b2g/gaia/commit/3f3ca2e6f8c2e64e5704d879ed8c7c79e6ce4dbd
Status: NEW → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S7 (24Oct)
You need to log in before you can comment on or make changes to this bug.