Closed Bug 1050679 Opened 7 years ago Closed 7 years ago
[Gaia][Settings] Use network info in state change event instead of read current network info
Most state change event already contains corresponding network info, and after bug 1050678, we expect have network info in every state change event. We could use these information while handling state change event to improve user experience.
Use wifi network information from event if available.
Comment on attachment 8475037 [details] [review] Pull Request Chuck, just left some comments on github, please give it a check !
7 years ago
Chuck, this patch should be landed after bug 1050678, right ? Because currently Gecko is not reflecting with this change, I'll keep the r? on my side and test after that got landed. WDYK !? :)
Basically they are good to me :)
That's reasonable, thanks!
Comment on attachment 8475037 [details] [review] Pull Request Sorry for the late reply, Chucklee. This patch looks ok to me and we just have too add one unit test for _updateNetworkStatus and update nits about indentations. Thanks !
Comment on attachment 8475037 [details] [review] Pull Request Fix nits and add unit test based existing test case.
Comment on attachment 8475037 [details] [review] Pull Request Thanks Chucklee ! r+ :)
Attachment #8475037 - Flags: review?(ejchen) → review+
7 years ago
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S7 (24Oct)
You need to log in before you can comment on or make changes to this bug.