Closed
Bug 1050719
Opened 10 years ago
Closed 10 years ago
Reduce overpaint of the calendar app
Categories
(Firefox OS Graveyard :: Gaia::Calendar, defect)
Firefox OS Graveyard
Gaia::Calendar
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: vingtetun, Unassigned)
References
Details
Attachments
(1 file)
|
576 bytes,
patch
|
evanxd
:
review+
|
Details | Diff | Splinter Review |
Kevin, this rules makes our rendering code unhappy. Just removing it shape a large chunk of overpaint and I can't see any changes in the app layout.
Attachment #8469945 -
Flags: review?(kgrandon)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8469945 [details] [diff] [review]
calendar.patch
Review of attachment 8469945 [details] [diff] [review]:
-----------------------------------------------------------------
Since Evan added this line for the visual refresh, I would like to defer the review to him so he can test it and ensure any edge cases are covered.
Also can we add a test for the overpaint fix?
Attachment #8469945 -
Flags: review?(kgrandon) → review?(evanxd)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8469945 [details] [diff] [review]
calendar.patch
Hi Vivien,
LGTM, thanks for the patch.
Attachment #8469945 -
Flags: review?(evanxd) → review+
|
Reporter | |
Comment 3•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•