1051006 - install addon doorhanger notifications not displaying

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[kevink9876543]

User Agent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Iron/31.0.1700.0 Chrome/31.0.1700.0 Safari/537.36

Steps to reproduce:

SeaMonkey 2.31 built from c-c rev 53be54f7311a / m-c rev 5e74101ce59e
new profile

Try to install NoScript latest development build from the link at
http://noscript.net/getit#devel


Actual results:

Nothing.  This gets logged to the Error Console:

Error: installInfo.originatingWindow is undefined
Source File: chrome://communicator/content/bindings/notification.xml
Line: 377

The only way to install that addon from that link is to download it with "Save Link Target As...", then drag&drop it into the SeaMonkey window.


Expected results:

I should have been presented with a doorhanger notification asking whether I wanted to install the software.

Comment 1

[Ian Neal]

On current trunk I get messages like:
Timestamp: 31/08/14 22:29:13
Error: installInfo.originatingWindow is undefined
Source File: chrome://communicator/content/bindings/notification.xml
Line: 401
Timestamp: 31/08/14 22:29:16
Error: installInfo.originatingWindow is undefined
Source File: chrome://communicator/content/bindings/notification.xml
Line: 383
Confirming

Comment 2

[Ian Neal]

Attachment: Switch from originatingWindow to originator [Checked in: Comment 5]

Looks like this was broken by Bug 952201 and landed on what is current m-a.

Comment 3

[[e-mail]]

Comment on attachment 8481985 [details] [diff] [review]
Switch from originatingWindow to originator [Checked in: Comment 5]

r=me by code inspection.

Comment 4

[Ian Neal]

Comment on attachment 8481985 [details] [diff] [review]
Switch from originatingWindow to originator [Checked in: Comment 5]

[Approval Request Comment]
Regression caused by (bug #): bug 952201
User impact if declined: Not able to install add-ons
Testing completed (on m-c, etc.): locally
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Comment 5

[Ian Neal]

Comment on attachment 8481985 [details] [diff] [review]
Switch from originatingWindow to originator [Checked in: Comment 5]

http://hg.mozilla.org/comm-central/rev/6db6e229ea45

Comment 7

[Philip Chee]

Comment on attachment 8481985 [details] [diff] [review]
Switch from originatingWindow to originator [Checked in: Comment 5]

(In reply to Ian Neal from comment #4)
> Comment on attachment 8481985 [details] [diff] [review]
> Switch from originatingWindow to originator [Checked in: Comment 5]
> 
> [Approval Request Comment]
> Regression caused by (bug #): bug 952201
> User impact if declined: Not able to install add-ons
> Testing completed (on m-c, etc.): locally
> Risk to taking this patch (and alternatives if risky): none
> String changes made by this patch: none
Please land on comm-beta 2.30b2 ASAP.

Comment 8

[Philip Chee]

Pushed to comm-beta:
http://hg.mozilla.org/releases/comm-beta/rev/c17de9d89bcf