1051061 - [verticalhome] TypeError: this.grid._grid.dragdrop is undefined

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[David Flanagan [:djf]]

This error message can appear in the logcat, at least in version 2.0 I saw it first in bug 1050751

I traced it to app.js:200. The dragdrop module is lazy loaded, so it is possible for that code to run before the dragdrop property is defined.   This is pretty obviously just a case where you need to test for its existance before using it.

I can reproduce the error by launching an app, using adb shell kill to kill the homescreen and then rapidly tapping multiple times on the home button.  This launches a new homescreen and then triggers that app.js:200 code before the lazy load is done.

_grid.dragdrop is also used without checking in the context menu code, but I didn't try to cause an error there.

Comment 1

[Kevin Grandon :kgrandon]

This should not cause any problems, but we should definitely fix it. Thanks for filing.

Comment 2

[Kevin Grandon :kgrandon]

Attachment: Github pull request

David - any chance you'd be willing to throw a review stamp on this since you reported it? :)

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8470307 [details] [review]
Github pull request

Hey Chris - any chance you have some cycles for a review? Thanks!

Comment 4

[Kevin Grandon :kgrandon]

[Blocking Requested - why for this release]: This is needed to help us solve bug 1048639 (a CAF blocker).

Comment 5

[Chris Lord [:cwiiis]]

Comment on attachment 8470307 [details] [review]
Github pull request

LGTM + points for test :)

Comment 6

[David Flanagan [:djf]]

Comment on attachment 8470307 [details] [review]
Github pull request

This looks good to me. I've noted a few nits on github, but nothing that I feel needs to be fixed.

Consider adding a similar fix in the contextmenu event case in contextmenu_handler.js before landing.

Comment 7

[Gregor Wagner [:gwagner]]

See comment 4

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 8470307 [details] [review]
Github pull request

Thanks for the review guys. I'm making some minor updates to the code based on David's comments and will land this.

Comment 9

[Kevin Grandon :kgrandon]

Master: https://github.com/mozilla-b2g/gaia/commit/c9b9925202c1419de201871fe40a431d41b50490

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/33123f5e8717b5001622a0f53ae4f90b5890f34d

Comment 11

[Nicholas Troast [:ntroast]]

attachment 8470307 [details] [review] has been landed in AU63