Simplify / clean up TypeNewScript

RESOLVED FIXED in mozilla34

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bhackett, Assigned: bhackett)

Tracking

unspecified
mozilla34
x86
macOS
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Posted patch patchSplinter Review
Currently extraneous data that is attached to TypeObject is done as a TypeObjectAddendum, for which TypeNewScript is the only subclass (there used to be another).  There isn't really any point to having this abstract class, so the attached patch removes it.  The patch also makes some other cleanups, mainly removing the ADDENDUM_CLEARED flag, which is unnecessary now since TypeNewScripts are only ever attached to TypeObjects when they are first created (this stuff used to work differently).
Attachment #8470399 - Flags: review?(jdemooij)
Comment on attachment 8470399 [details] [diff] [review]
patch

Review of attachment 8470399 [details] [diff] [review]:
-----------------------------------------------------------------

Nice cleanup.
Attachment #8470399 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/abe747ee0aca
Assignee: nobody → bhackett1024
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.