Closed
Bug 1051155
Opened 10 years ago
Closed 10 years ago
Simplify / clean up TypeNewScript
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
Details
Attachments
(1 file)
|
31.60 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
Currently extraneous data that is attached to TypeObject is done as a TypeObjectAddendum, for which TypeNewScript is the only subclass (there used to be another). There isn't really any point to having this abstract class, so the attached patch removes it. The patch also makes some other cleanups, mainly removing the ADDENDUM_CLEARED flag, which is unnecessary now since TypeNewScripts are only ever attached to TypeObjects when they are first created (this stuff used to work differently).
Attachment #8470399 -
Flags: review?(jdemooij)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8470399 [details] [diff] [review] patch Review of attachment 8470399 [details] [diff] [review]: ----------------------------------------------------------------- Nice cleanup.
Attachment #8470399 -
Flags: review?(jdemooij) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/abe747ee0aca
|
||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/abe747ee0aca
Assignee: nobody → bhackett1024
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
|
||
Updated•10 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•