1051219 - TypeError: activeIme is undefined in render.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

STR:

1. Switch to English layout and kill the keyboard
2. Focus on an empty input and monitor the console log

Expected:

1. No JS Error

Actual:

1. JS Error

Note:

The reason of this error is because latin.js attempts to update the upper case status before the rendering exists. We either need to workaround this JS error or try to activate IMEngine only until the rendering for it exists.

Fortunately the error is currently harmless and does not stop the promise chain from complete (since the call is wrapped in a requireAnimationFrame in handleUpperCaseStateChange).

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

WIP https://github.com/timdream/gaia/tree/keyboard-uppercase-rendering

I might try other approach.

Comment 2

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#24041

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8489261 [details] [review]
mozilla-b2g:master PR#24041

This patch centralized some of the calls to IMERender and add a protection in RenderingManager to make sure we don't call it when the layout is not updated.

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8489261 [details] [review]
mozilla-b2g:master PR#24041

Looks good to me.
Thanks.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/34659442d1ee1d6aab20b4e6662134ffe0cc0bd6