Closed
Bug 1051219
Opened 10 years ago
Closed 10 years ago
TypeError: activeIme is undefined in render.js
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S5 (26sep)
People
(Reporter: timdream, Assigned: timdream)
Details
(Whiteboard: [p=3])
Attachments
(1 file)
STR: 1. Switch to English layout and kill the keyboard 2. Focus on an empty input and monitor the console log Expected: 1. No JS Error Actual: 1. JS Error Note: The reason of this error is because latin.js attempts to update the upper case status before the rendering exists. We either need to workaround this JS error or try to activate IMEngine only until the rendering for it exists. Fortunately the error is currently harmless and does not stop the promise chain from complete (since the call is wrapped in a requireAnimationFrame in handleUpperCaseStateChange).
Assignee | ||
Updated•10 years ago
|
Target Milestone: --- → 2.1 S2 (15aug)
Assignee | ||
Comment 1•10 years ago
|
||
WIP https://github.com/timdream/gaia/tree/keyboard-uppercase-rendering I might try other approach.
Assignee | ||
Updated•10 years ago
|
Target Milestone: 2.1 S2 (15aug) → ---
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8489261 [details] [review] mozilla-b2g:master PR#24041 This patch centralized some of the calls to IMERender and add a protection in RenderingManager to make sure we don't call it when the layout is not updated.
Attachment #8489261 -
Flags: review?(rlu)
Comment 4•10 years ago
|
||
Comment on attachment 8489261 [details] [review] mozilla-b2g:master PR#24041 Looks good to me. Thanks.
Attachment #8489261 -
Flags: review?(rlu) → review+
Assignee | ||
Comment 5•10 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/34659442d1ee1d6aab20b4e6662134ffe0cc0bd6
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S5 (26sep)
You need to log in
before you can comment on or make changes to this bug.
Description
•