1051526 - DevTools Themes: remove padding from sidebar tabs

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Albert Juhé]

Attachment: screenshot.png

When I was solving Bug 1049029, I realized there is a strange padding in the sidebar tabs that makes the title to be a little bit moved to the right.

It's just one or two pixels, but when tabs are very small, it can be perceived.

Comment 1

[Albert Juhé]

Attachment: bug1051526.patch

Removing some paddings the issue is solved. I'm not sure why there were those paddings, though.

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8470469 [details] [diff] [review]
bug1051526.patch

Review of attachment 8470469 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like those values were copied over from the initial creation of the shared toolbars.inc.css: https://hg.mozilla.org/mozilla-central/rev/71fcb255a8cf. The only thing I can think is if that was overriding some UA styles, but I'm not really seeing anything in toolkit/themes/*/global/tabbox.css that looks relevant.  And this looks fine, so I'd say it is good to go.

Comment 3

[Brian Grinstead [:bgrins]]

https://hg.mozilla.org/integration/fx-team/rev/65615ff8eb40

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/65615ff8eb40

Comment 5

[Karthikeyan]

Verified [bugday-20140813]

Explanation: 

There is no strange padding on sidebar tabs.