1051653 - [email][l10n] v1.4-specific l10n workaround to close the mail app when the language changes

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Andrew Sutherland [:asuth] (he/him)]

Attachment: v1.4 pull request to close the email app on locale change

[e-mail] has indicated a desire for us to improve the l10n situation on the v1.4 branch further than what we've already done with the uplift of bug 1008859.  Discussion starts at https://bugzilla.mozilla.org/show_bug.cgi?id=906580#c14 but the main takeaways is that:

It's acceptable to everyone if we just have the email app close itself on language change on the v1.4 branch since it addresses the parts of the email app that (on v1.4) do not dynamically re-localize and it's very easy.

We have a pull request up at https://github.com/mozilla-b2g/gaia/pull/22604 that [e-mail] has already tested.

From bug 1008859 discussion it's my understanding that since Spreadtrum is the canonical user of the v1.4 branch so this is an easy call to land this on v1.4 (and *only* v1.4).

:jrburke, I infer from the other activity on that bug that you're okay with this patch, but r?-ing you to be sure.

Comment 1

[James Burke [:jrburke]]

Comment on attachment 8470588 [details] [review]
v1.4 pull request to close the email app on locale change

Based on testing that was indicated that was done on the 1.4 branch, looks fine to me, and better trying to get all the other changes on the 1.4 branch.

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

[Blocking Requested - why for this release]:
No one is triaging our approval-gaia-v1.4? request, so I am trying to get someone to look at this bug and give approval.  See comment 0 for context.

Comment 3

[Wayne Chang [:wchang]]

Triage -

This is not a critical bug and the use case is uncommon. l10n is correct upon relaunching email app.

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Thanks for the triage.  I'm accordingly marking this bug invalid since we don't want to take this v1.4-specific fix.