Closed Bug 1051660 Opened 9 years ago Closed 9 years ago

Test case for Wifi enable API

Categories

(Firefox OS Graveyard :: Wifi, defect)

Product:
Firefox OS Graveyard
Component:
Wifi
Platform:
x86_64
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.1 S3 (29aug)

People

(Reporter: hchang, Assigned: chucklee)

References

Details

(Whiteboard: [p=2])

Attachments

(2 files, 2 obsolete files)

0001. Fix minor bugs in API implementation.
1.77 KB, patch
hchang
: review+
Details | Diff | Splinter Review
0002. Test case for Wifi Enable API.
3.59 KB, patch
hchang
: review+
Details | Diff | Splinter Review 
We need test cases for new wifi API 'setWifiEnabled' which was
introduced by Bug 930355
Depends on: 930355
Assignee: nobody → chulee
Comment on attachment 8471426 [details] [diff] [review]
(WIP) 0002. Test case for Wifi Enable API.

Review of attachment 8471426 [details] [diff] [review]:
-----------------------------------------------------------------

Looks perfect! It would be better to modify 
comments for requestWifiEnabled!

Thanks!
Attachment #8471426 - Flags: feedback?(hchang) → feedback+
Comment on attachment 8471424 [details] [diff] [review]
(WIP) 0001. Fix minor bugs in API implementation.

Review of attachment 8471424 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! Thanks!
Attachment #8471424 - Flags: feedback?(hchang) → feedback+
Comment on attachment 8474386 [details] [diff] [review]
0002. Test case for Wifi Enable API.

Review of attachment 8474386 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for adding comments!
Attachment #8474386 - Flags: review?(hchang) → review+
Comment on attachment 8474382 [details] [diff] [review]
0001. Fix minor bugs in API implementation.

Review of attachment 8474382 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! Thanks!
Attachment #8474382 - Flags: review?(hchang) → review+
Target Milestone: --- → 2.1 S3 (29aug)
You need to log in before you can comment on or make changes to this bug.