Closed
Bug 1051660
Opened 11 years ago
Closed 11 years ago
Test case for Wifi enable API
Categories
(Firefox OS Graveyard :: Wifi, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S3 (29aug)
People
(Reporter: hchang, Assigned: chucklee)
References
Details
(Whiteboard: [p=2])
Attachments
(2 files, 2 obsolete files)
|
1.77 KB,
patch
|
hchang
:
review+
|
Details | Diff | Splinter Review |
|
3.59 KB,
patch
|
hchang
:
review+
|
Details | Diff | Splinter Review |
We need test cases for new wifi API 'setWifiEnabled' which was
introduced by Bug 930355
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → chulee
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8471424 -
Flags: feedback?(hchang)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #8471426 -
Flags: feedback?(hchang)
|
Reporter | |
Comment 3•11 years ago
|
||
Comment on attachment 8471426 [details] [diff] [review]
(WIP) 0002. Test case for Wifi Enable API.
Review of attachment 8471426 [details] [diff] [review]:
-----------------------------------------------------------------
Looks perfect! It would be better to modify
comments for requestWifiEnabled!
Thanks!
Attachment #8471426 -
Flags: feedback?(hchang) → feedback+
|
|
Reporter | |
Comment 4•11 years ago
|
||
Comment on attachment 8471424 [details] [diff] [review]
(WIP) 0001. Fix minor bugs in API implementation.
Review of attachment 8471424 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good! Thanks!
Attachment #8471424 -
Flags: feedback?(hchang) → feedback+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Rebase.
Attachment #8471424 -
Attachment is obsolete: true
Attachment #8474382 -
Flags: review?(hchang)
|
|
Assignee | |
Comment 6•11 years ago
|
||
Address comment 3 and change test order.
Try passed : https://tbpl.mozilla.org/?tree=Try&rev=3d7b9332d013
Attachment #8471426 -
Attachment is obsolete: true
Attachment #8474386 -
Flags: review?(hchang)
|
|
Reporter | |
Comment 7•11 years ago
|
||
Comment on attachment 8474386 [details] [diff] [review]
0002. Test case for Wifi Enable API.
Review of attachment 8474386 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for adding comments!
Attachment #8474386 -
Flags: review?(hchang) → review+
|
|
Reporter | |
Comment 8•11 years ago
|
||
Comment on attachment 8474382 [details] [diff] [review]
0001. Fix minor bugs in API implementation.
Review of attachment 8474382 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good! Thanks!
Attachment #8474382 -
Flags: review?(hchang) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Updated•11 years ago
|
Target Milestone: --- → 2.1 S3 (29aug)
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [p=2]
|
||
Comment 9•11 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/f40fc7c75b34
https://hg.mozilla.org/integration/b2g-inbound/rev/5ef6fa57dc3b
Flags: in-testsuite+
Keywords: checkin-needed
|
|
||
Comment 10•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f40fc7c75b34
https://hg.mozilla.org/mozilla-central/rev/5ef6fa57dc3b
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•