Closed Bug 1051663 Opened 10 years ago Closed 10 years ago

[Telephony] Correct |this| in REQUEST_DIAL_EMERGENCY_CALL

Categories

(Firefox OS Graveyard :: RIL, defect)

Product:
Firefox OS Graveyard
Component:
RIL
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.0+, firefox32 wontfix, firefox33 wontfix, firefox34 fixed, b2g-v2.0 fixed, b2g-v2.1 fixed)

Status:
RESOLVED FIXED
Milestone:
2.1 S2 (15aug)
Project Flags:
blocking-b2g 2.0+
Tracking Flags:
Tracking Status
firefox32 --- wontfix
firefox33 --- wontfix
firefox34 --- fixed
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: aknow, Assigned: aknow)

Details

Attachments

(1 file, 1 obsolete file)

[final] Correct |this| in REQUEST_DIAL_EMERGENCY_CALL. r=hsinyi
1.05 KB, patch
aknow
: review+
Details | Diff | Splinter Review 
      No description provided.

        Attachment #8470609 -
        Flags: review?(htsai)

        Attachment #8470609 -
        Flags: review?(htsai) → review+

    
    

    
  
Comment on attachment 8470726 [details] [diff] [review]
[final] Correct |this| in REQUEST_DIAL_EMERGENCY_CALL. r=hsinyi

NOTE: This flag is now for security issues only. Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): a new bug
User impact if declined: 
  Affect Woodduck. All emergency calls will fail. And after that, user cannot dial out normal call.
Testing completed: n/a
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: n/a

        Attachment #8470726 -
        Flags: approval-mozilla-b2g32?

    
  

        Attachment #8470609 -
        Attachment is obsolete: true

    
    

    
  
Please land on mc and 2.0 as well (after approval)
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/104833d06143
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S2 (15aug)

    
    

    
  
[Blocking Requested - why for this release]: woodduck will need this patch to complete the ECC features.
blocking-b2g: --- → 2.0?

    
    

    
  
This is certification blocker, so blocking+. Please land on 2.0 branch, thank you!
blocking-b2g: 2.0? → 2.0+

        Attachment #8470726 -
        Flags: approval-mozilla-b2g32?

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: