1051664 - B2G RIL: Add marionette tests for EF_OPL wild char

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[shawn ku [:sku]]

By checking the code in [1], gecko did not handle wild char properly while reading EF_OPL. It will cause wrong operator name display if there is any wild char pre-allocated in SIM EF_OPL.


// 3GPP TS 31.102, clause 4.2.59 EFOPL (Operator PLMN List)
...
Coding:
PLMN : according to TS 24.008 [9]/TS 24.301 [51]
A BCD value of 'D' in any of the MCC and/or MNC digits shall be used to indicate a "wild" value for that
corresponding MCC/MNC digit

[1] - http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/ril_worker.js?from=ril_worker.js&case=true#14190

Comment 1

[shawn ku [:sku]]

Bug 1046649 was filed for 1.3t/1.4 only due to time-to-market. Bug 1051664 is filed to re-consider the solution/test cases on m-c.

Comment 2

[Edgar Chen [:edgar]]

(In reply to shawn ku [:sku] from comment #1)
> Bug 1046649 was filed for 1.3t/1.4 only due to time-to-market. Bug 1051664
> is filed to re-consider the solution/test cases on m-c.

According to the landing rule [1], we should land patches to master first then uplift to 1.4 branch, the landing process will be done in bug 1046649. This bug now focus on adding marionette test for EF_OPL wild char.

[1] https://wiki.mozilla.org/Release_Management/B2G_Landing

Comment 3

[shawn ku [:sku]]

Attachment: Bug 1051664 Part1: qemu patch - B2G RIL: Add marionette tests for EF_OPL wild char.

Comment 4

[shawn ku [:sku]]

Attachment: Bug 1051664 Part2: test patch - B2G RIL: Add marionette tests for EF_OPL wild char.

Comment 5

[shawn ku [:sku]]

Comment on attachment 8475062 [details] [review]
Bug 1051664 Part1: qemu patch - B2G RIL: Add marionette tests for EF_OPL wild char.

Hi Vicamo:
 Can I have your time to review this PR?
Thanks!!
Shawn

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 8475062 [details] [review]
Bug 1051664 Part1: qemu patch - B2G RIL: Add marionette tests for EF_OPL wild char.

Hi, we have all mcc set to 001 because it's explicitly listed in Test Networks in wikipedia. Since Gaia have its own operator variants db, I'd like to avoid possible collisions if that doesn't cost much effort. And surely it doesn't. You may simply set OPL item 5 to be effective only with mcc=001, mnc=2dd, and OPL item 6 with mcc=001, mnc=20d. Thank you.

[1]: http://en.wikipedia.org/wiki/Mobile_country_code#Test_networks

Comment 7

[shawn ku [:sku]]

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #6)
> Comment on attachment 8475062 [details] [review]
> Bug 1051664 Part1: qemu patch - B2G RIL: Add marionette tests for EF_OPL
> wild char.
> 
> Hi, we have all mcc set to 001 because it's explicitly listed in Test
> Networks in wikipedia. Since Gaia have its own operator variants db, I'd
> like to avoid possible collisions if that doesn't cost much effort. And
> surely it doesn't. You may simply set OPL item 5 to be effective only with
> mcc=001, mnc=2dd, and OPL item 6 with mcc=001, mnc=20d. Thank you.
> 
> [1]: http://en.wikipedia.org/wiki/Mobile_country_code#Test_networks

Thanks for your time!!

Can I simply change it to:
    //     MCC = 001, MNC =  2D, START=0000, END=FFFE, PNN = 05,
    //     MCC = 001, MNC = 3DD, START=0000, END=FFFE, PNN = 06,
because 20d is a subset of 2dd, 001-20d will always be treated as the same as 001-2dd.

Comment 8

[Vicamo Yang [:vicamo][:vyang]]

(In reply to shawn ku [:sku] from comment #7)
> Thanks for your time!!
> 
> Can I simply change it to:
>     //     MCC = 001, MNC =  2D, START=0000, END=FFFE, PNN = 05,
>     //     MCC = 001, MNC = 3DD, START=0000, END=FFFE, PNN = 06,
> because 20d is a subset of 2dd, 001-20d will always be treated as the same
> as 001-2dd.

Sure. That was one of questions in my mind when I first saw your pull request. I thought that was intended so that you may test some kind of fallback algorithm.

Comment 9

[shawn ku [:sku]]

Attachment: Bug 1051664 - B2G RIL: Add marionette tests for EF_OPL wild char. v2.

Comment 10

[shawn ku [:sku]]

Attachment: Bug 1051664 Part2: test patch - B2G RIL: Add marionette tests for EF_OPL wild char.1051664.test.patch

Comment 11

[shawn ku [:sku]]

Attachment: Bug 1051664 Part1 : qemu patch - B2G RIL: Add marionette tests for EF_OPL wild char. v2.

Comment 12

[shawn ku [:sku]]

Attachment: Bug 1051664 Part2 : test patch - B2G RIL: Add marionette tests for EF_OPL wild char.

Comment 13

[shawn ku [:sku]]

Comment on attachment 8475776 [details] [diff] [review]
Bug 1051664 Part2 : test patch - B2G RIL: Add marionette tests for EF_OPL wild char.

Review of attachment 8475776 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Edgar:
 May I have your time to review?
Thanks!!
Shawn

Comment 14

[Edgar Chen [:edgar]]

Comment on attachment 8475776 [details] [diff] [review]
Bug 1051664 Part2 : test patch - B2G RIL: Add marionette tests for EF_OPL wild char.

Review of attachment 8475776 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thank you.

Comment 15

[shawn ku [:sku]]

Attachment: Bug 1051664 Part1 : qemu patch - B2G RIL: Add marionette tests for EF_OPL wild char. v2. r=Vicamo.

Comment 16

[shawn ku [:sku]]

Attachment: Bug 1051664 Part2 : test patch - B2G RIL: Add marionette tests for EF_OPL wild char. r=Edgar.

Comment 17

[shawn ku [:sku]]

Hi Vicamo:
 Could you please help push the PR for me?
I would like to run the full marionette test before submit gecko patch.

Thanks!! 

Local result:
-------
 2:45.85 LOG: MainThread INFO passed: 32
 2:45.85 LOG: MainThread INFO failed: 0
 2:45.85 LOG: MainThread INFO todo: 0
 2:46.97 SUITE_END: MainThread 
Summary
=======

Ran 32 tests
Expected results: 32
Unexpected results: 0

OK

Comment 18

[Vicamo Yang [:vicamo][:vyang]]

https://github.com/mozilla-b2g/platform_external_qemu/commit/c058843242068d0df7c107e09da31b53d2e08fa6

Comment 19

[Vicamo Yang [:vicamo][:vyang]]

(In reply to shawn ku [:sku] from comment #17)
> Hi Vicamo:
>  Could you please help push the PR for me?
> I would like to run the full marionette test before submit gecko patch.

You don't need this next time. You may edit '${gecko}/b2g/configs/emulator-ics/sources.xml', push it to tryserver as other ordinary patches do.

Comment 20

[shawn ku [:sku]]

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #19)
> (In reply to shawn ku [:sku] from comment #17)
> > Hi Vicamo:
> >  Could you please help push the PR for me?
> > I would like to run the full marionette test before submit gecko patch.
> 
> You don't need this next time. You may edit
> '${gecko}/b2g/configs/emulator-ics/sources.xml', push it to tryserver as
> other ordinary patches do.

Thanks for your useful information. :-)

Comment 21

[shawn ku [:sku]]

https://tbpl.mozilla.org/?tree=Try&rev=1e9c8245d6e4
try green

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/365ba1ee68ff

Comment 23

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/365ba1ee68ff