Closed
Bug 1051668
Opened 10 years ago
Closed 10 years ago
need reftest data for font-variant-alternates tests
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: jtd, Assigned: jtd)
References
Details
Attachments
(2 files)
|
61.54 KB,
patch
|
m_kato
:
review+
|
Details | Diff | Splinter Review |
|
4.60 KB,
patch
|
m_kato
:
review+
|
Details | Diff | Splinter Review |
Not quite sure how this happened but the initial landing of font feature reftests (bug 549861) failed to include the proper set of data for the 'font-variant-alternates' property. There's a testpage for font-variant-alternates but with no data in 'font-variant-features.js', it's basically a blank page vs. blank page comparison.
Also, the gsubtest fonts need to be rev'ved to allow for styleset values between [21..99]. These aren't defined by the OpenType layout feature tag registry but the CSS3 Fonts spec allows these (late revision of the spec).
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → jdaggett
|
|
Assignee | |
Comment 1•10 years ago
|
||
Add ss22..ss99 to gsubtest-features.txt and rebuild fonts
Attachment #8470629 -
Flags: review?(m_kato)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Add in testdata for font-variant-alternates to font-variant-features.js (these were cleverly omitted from the original checkin, doh!)
Attachment #8470630 -
Flags: review?(m_kato)
|
||
Updated•10 years ago
|
Attachment #8470629 -
Flags: review?(m_kato) → review+
|
|
||
Updated•10 years ago
|
Attachment #8470630 -
Flags: review?(m_kato) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fa47185dbc7c
https://hg.mozilla.org/mozilla-central/rev/8faf629efcad
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•