Closed Bug 1051689 Opened 7 years ago Closed 7 years ago

[TSF] Should call RecordCompositionUpdateAction() when adding a pending action and the last compositionupdate is incomplete

Categories

(Core :: Widget: Win32, defect)

x86_64
Windows 8.1
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

(Keywords: inputmethod)

Attachments

(1 file)

No description provided.
Attached patch PatchSplinter Review
This follow up patch for bug 1049768. When I test another bug with ATOK, I found this warning in the log.
Attachment #8470766 - Flags: review?(VYV03354)
Comment on attachment 8470766 [details] [diff] [review]
Patch

> EnsureToCompleteIfLastActionIsStillIncomplete

This is a bit too verbose IMO. I would name it "CompleteLastActionIfStillIncomplete". (disclaimer: I'm not a native English speaker :) )
Attachment #8470766 - Flags: review?(VYV03354) → review+
(In reply to Masatoshi Kimura [:emk] from comment #2)
> Comment on attachment 8470766 [details] [diff] [review]
> Patch
> 
> > EnsureToCompleteIfLastActionIsStillIncomplete
> 
> This is a bit too verbose IMO. I would name it
> "CompleteLastActionIfStillIncomplete". (disclaimer: I'm not a native English
> speaker :) )

Yep. Sounds better to me too.
https://hg.mozilla.org/mozilla-central/rev/873b1855df55
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.