1051689 - [TSF] Should call RecordCompositionUpdateAction() when adding a pending action and the last compositionupdate is incomplete

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

This follow up patch for bug 1049768. When I test another bug with ATOK, I found this warning in the log.

Comment 2

[Masatoshi Kimura [:emk]]

Comment on attachment 8470766 [details] [diff] [review]
Patch

> EnsureToCompleteIfLastActionIsStillIncomplete

This is a bit too verbose IMO. I would name it "CompleteLastActionIfStillIncomplete". (disclaimer: I'm not a native English speaker :) )

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Masatoshi Kimura [:emk] from comment #2)
> Comment on attachment 8470766 [details] [diff] [review]
> Patch
> 
> > EnsureToCompleteIfLastActionIsStillIncomplete
> 
> This is a bit too verbose IMO. I would name it
> "CompleteLastActionIfStillIncomplete". (disclaimer: I'm not a native English
> speaker :) )

Yep. Sounds better to me too.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Forgot to say, thank you for the quick review!

https://hg.mozilla.org/integration/mozilla-inbound/rev/873b1855df55

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/873b1855df55