All users were logged out of Bugzilla on October 13th, 2018

[Loop] The notification is not a sound or a vibration, (it can't be heared or felt) if the device is in vibration mode when the call or video call is establishing.

VERIFIED FIXED

Status

--
major
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: javier.deprado, Assigned: carmen.jimenezcabezas)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mobile app][not blocking][tef-triage][patch available])

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

4 years ago
Device: fireE
Version: d9507c2

STR
1.- Put Device B in vibration mode. 
2.- Device A makes a call to device B.


ACTUAL RESULT
1.- No sound is heard or vibration is felt, when the call is establishing.

EXPECTED RESULT
According to the test case, the notification should be a vibration.
(Reporter)

Updated

4 years ago
Blocks: 1036490
(Reporter)

Updated

4 years ago
Summary: [Loop] The the notification is not a sound or a vibration, ( (it can't be heared) if the device is in vibration mode when the call or video call is establishing. → [Loop] The the notification is not a sound or a vibration, ( (it can't be heared or felt) if the device is in vibration mode when the call or video call is establishing.
(Reporter)

Updated

4 years ago
Whiteboard: [mobile app]
This issue still occurs on the latest 2.0 build with the v165 KK base. The phone does not vibrate when receiving a call.

Environmental Variables:
Device: Flame 2.0
BuildID: 20140819030000
Gaia: 287a2c725a5c14e5dc1d48e3158ffc79c7d1ea33
Gecko: 6329352ca531b977979451e77e5862af485388b2
Version: 32.0 (2.0) 
Firmware Version: v165
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0


Loop version: 32219a2
If the device has the vibration mode activated, it should vibrate when an incoming call is received.
Whiteboard: [mobile app] → [mobile app][blocking]
Severity: normal → major
Whiteboard: [mobile app][blocking] → [mobile app][blocking][tef-triage]
(Assignee)

Updated

4 years ago
Assignee: nobody → carmen.jimenezcabezas
(Reporter)

Updated

4 years ago
Summary: [Loop] The the notification is not a sound or a vibration, ( (it can't be heared or felt) if the device is in vibration mode when the call or video call is establishing. → [Loop] The notification is not a sound or a vibration, ( (it can't be heared or felt) if the device is in vibration mode when the call or video call is establishing.
After talking with Product team and for this first Loop mobile client version, we would try to include the vibration setting into the Loop mobile app settings. 

Vicky, Pau can you help us with this issue?
Flags: needinfo?(vpg)
Flags: needinfo?(b.pmm)
(Assignee)

Comment 4

4 years ago
Created attachment 8496270 [details] [review]
V1 Proposed patch
(Assignee)

Comment 5

4 years ago
Created attachment 8496287 [details]
screenshot proposed setting

Comment 6

4 years ago
It works for me. Thanks!
Flags: needinfo?(b.pmm)
Whiteboard: [mobile app][blocking][tef-triage] → [mobile app][blocking][tef-triage][patch available]
Status: NEW → ASSIGNED
Summary: [Loop] The notification is not a sound or a vibration, ( (it can't be heared or felt) if the device is in vibration mode when the call or video call is establishing. → [Loop] The notification is not a sound or a vibration, (it can't be heared or felt) if the device is in vibration mode when the call or video call is establishing.
Looks ok.
Flags: needinfo?(vpg)
(Assignee)

Updated

4 years ago
Attachment #8496270 - Flags: review?(borja.bugzilla)
Attachment #8496270 - Flags: review?(b.pmm)

Comment 8

4 years ago
Carmen, could you upload a screenshot so I can review it better than the code, please? ;)

Comment 9

4 years ago
Sorry, can you ask Vicky for review better? Thanks.
Comment on attachment 8496270 [details] [review]
V1 Proposed patch

Some comments to address! Let me know when ready and I'll review it again. Thanks!
Attachment #8496270 - Flags: review?(borja.bugzilla) → feedback+
(Assignee)

Comment 11

4 years ago
Created attachment 8498753 [details]
v2 screenshot proposed setting
Attachment #8496287 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Attachment #8496270 - Flags: review?(b.pmm) → review?(borja.bugzilla)
Whiteboard: [mobile app][blocking][tef-triage][patch available] → [mobile app][not blocking][tef-triage][patch available]
Comment on attachment 8496270 [details] [review]
V1 Proposed patch

Some changes still needed. We are quite close to have this sorted out!
Attachment #8496270 - Flags: review?(borja.bugzilla)
(Assignee)

Comment 13

4 years ago
Created attachment 8499912 [details]
v2 screenshot proposed setting - ES
(Assignee)

Updated

4 years ago
Attachment #8496270 - Flags: review?(borja.bugzilla)
Comment on attachment 8496270 [details] [review]
V1 Proposed patch

We need to store & update just one object, not every setting as a separate entity. This will save a lot of lines of code and we will remove a source of error. Let me know when ready!
Attachment #8496270 - Flags: review?(borja.bugzilla)
Comment on attachment 8496270 [details] [review]
V1 Proposed patch

Thanks for the patch! Please rebase & merge!
Attachment #8496270 - Flags: review+
(Assignee)

Comment 16

4 years ago
https://github.com/mozilla-b2g/firefoxos-loop-client/commit/0c338106adc7f056068db55b212ef6682c05ed8a
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Reporter)

Comment 17

4 years ago
Loop version: dbe5fb3
Build version: Gecko-7107b06.Gaia-c1f6089
RAM: 512M


STR:
1.- Login loop app in Device-A and Device-B (check settings are in default mode -> vibrate mode ON)
2.- Open loop settings in device-B and disable vibrate mode.
3.- Instead of tapping "Done" button, kill loop app long tapping from home button.
4.- Make a call from Device-A to Device-B, and check that Device-B is not vibrating, and check that vibration mode in settings, is set to OFF.
5.- Enable vibration mode in Device-B, and kill again loop app long tapping from home button.
6.- Make a call from Device-A to Device-B

ACTUAL RESULT: Device-B is not vibrating and in loop setting vibration mode is enabled.

EXPECTED RESULT: Killing loop app without tapping "Done" button in loop settings, should change the vibration mode. (in the same way as in "default call mode" and "Camera")
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 18

4 years ago
It isn't a vibration setting problem and it doesn't depend of how you close the setting panel (tapping "Done" button or killing loop).

Regardless the value that the settings have, if the loop app receives a call while it's closed, the incoming call always will use the back camera and won't vibrate because the call screen manager is launched before the settings have been initialized.

It isn't a vibration setting problem and it doesn't depend of how you close the setting panel (tapping "Done" button or killing loop).

Regardless the value that the settings have, if the loop app receives a call while it's closed, the incoming call ever will be with backCamera and vibrate off because the callScreenManager is launched before the settings have had time of initialize themselves.

I've opened the bug 1080756 for this issue.
(Assignee)

Comment 19

4 years ago
Resolved in bug 1080756
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Resolution: --- → FIXED
(Reporter)

Comment 20

4 years ago
Verified on flame and fireE
Loop version: 2168965
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.