Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Change user to emailuser in hg annotate web interface

VERIFIED FIXED

Status

Developer Services
Mercurial: hg.mozilla.org
VERIFIED FIXED
3 years ago
a year ago

People

(Reporter: nONoNonO, Assigned: emorley)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
The current hgweb interface shows my contributions as o. My username is o.e.ekker@gmail.com, which gets abbreviated to o. If you display emailuser instead of user, o.e.ekker would be shown.
See also http://bz.selenic.com/show_bug.cgi?id=2276 for more info.
An example of current annotate can be seen here:
http://hg.mozilla.org/releases/l10n/mozilla-aurora/nl/annotate/087b0af1cc16/chat/conversations.properties#l42
(Assignee)

Updated

3 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 7 → All
Hardware: x86 → All
(Assignee)

Comment 1

3 years ago
Created attachment 8471469 [details] [diff] [review]
Use |emailuser| rather than |user| for the annotate author

Unfortunately it would seem that the 'emailuser' filter requires Hg v2.2 or higher:
http://www.selenic.com/hg/rev/e5788269741a
Also search for "templates/filters: extracting the user portion of an email address (BC)" on http://mercurial.selenic.com/wiki/WhatsNew

As far as I can tell we're on 2.0.2 on hg.mozilla.org at present (bug 623505), and bug 945383 is where further upgrade discussions have taken place.
(Assignee)

Updated

3 years ago
Blocks: 945383
(Assignee)

Updated

3 years ago
Assignee: nobody → emorley
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 years ago
Bug 945383 comment 4 says we're running 2.5.4, so this should work fine :-)
No longer blocks: 945383
(Assignee)

Comment 3

3 years ago
Comment on attachment 8471469 [details] [diff] [review]
Use |emailuser| rather than |user| for the annotate author

For legacy reasons, the 'user' filter incorrectly turns email addresses of form
'a.b.surname@domain.org' into 'a'. Using 'emailuser' instead gives the entire
part before the @, ie 'a.b.surname' - and so this patch means that on the hgweb
annotate pages the author username shown for each line is less ambiguous.

Requires Hg v2.2 or higher; hg.m.o is running 2.5.4.

See also: http://bz.selenic.com/show_bug.cgi?id=2276
Attachment #8471469 - Flags: review?(ted)
Attachment #8471469 - Flags: review?(ted) → review+
(Assignee)

Comment 4

3 years ago
Comment on attachment 8471469 [details] [diff] [review]
Use |emailuser| rather than |user| for the annotate author

Thank you :-)

https://hg.mozilla.org/hgcustom/hg_templates/rev/781a6d82af8c
Attachment #8471469 - Flags: checked-in+
(Assignee)

Updated

3 years ago
Depends on: 1052570
(Assignee)

Comment 5

3 years ago
In production; seems to work :-)
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Reporter)

Comment 6

3 years ago
Thank you for this quick change! I'm sure glad you don;t have change advisory boards and releases and thing like that for changes like this
Status: RESOLVED → VERIFIED

Comment 7

3 years ago
https://hg.mozilla.org/hgcustom/version-control-tools/rev/1b1c2f8de55c
Product: Release Engineering → Developer Services
(Reporter)

Updated

a year ago
See Also: → bug 1262360
You need to log in before you can comment on or make changes to this bug.