1051987 - Hide the disabled commands in mach by default

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

Attachment: 0001-By-default-hide-the-disabled-commands.patch

By default, hide the disabled commands.
They are eating the display for no value to the developer. Especially at the end of the display...
What really matter are the available commands.

$ ./mach -v help
bring them back.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: 0001-By-default-hide-the-disabled-commands.patch

With the correct patch.

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8470922 [details] [diff] [review]
0001-By-default-hide-the-disabled-commands.patch

Review of attachment 8470922 [details] [diff] [review]:
-----------------------------------------------------------------

I approve of this.

Does |mach help| print the "The disabled commands are hidden by default. Use -v to display them." message with this patch? If not, that could lead to confusion. I'd really like a notice at the bottom of |mach help| stating the existence of disabled commands and how to access info on them.

::: python/mach/mach/dispatcher.py
@@ +196,4 @@
>          if disabled_commands and 'disabled' in r.categories:
>              title, description, _priority = r.categories['disabled']
>              group = parser.add_argument_group(title, description)
> +            if verbose == True:

|if foo == True| is almost always a bad idea. Just use |if foo|.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

(In reply to Gregory Szorc [:gps] from comment #2)

> Does |mach help| print the "The disabled commands are hidden by default. Use
> -v to display them." message with this patch? If not, that could lead to
> confusion. I'd really like a notice at the bottom of |mach help| stating the
> existence of disabled commands and how to access info on them.
Yes, it does.

Without "-v", the result is:
[...]
  webidl-example        Generate example files for a WebIDL interface.

Disabled:
  The disabled commands are hidden by default. Use -v to display them. These
  commands are unavailable for your current context, run "mach <command>" to
  see why.


> ::: python/mach/mach/dispatcher.py
> @@ +196,4 @@
> >          if disabled_commands and 'disabled' in r.categories:
> >              title, description, _priority = r.categories['disabled']
> >              group = parser.add_argument_group(title, description)
> > +            if verbose == True:
> 
> |if foo == True| is almost always a bad idea. Just use |if foo|.
Right. Thanks.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8470922 [details] [diff] [review]
0001-By-default-hide-the-disabled-commands.patch

Review of attachment 8470922 [details] [diff] [review]:
-----------------------------------------------------------------

great stuff here.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

here it is:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ed3ec8f1787

but I wrongly committed some wrong code which I removed here:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8fa6ace05e73

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Merged:
https://hg.mozilla.org/mozilla-central/rev/4ed3ec8f1787