Enable CloudSync in Nightly

RESOLVED FIXED in Firefox 34

Status

Cloud Services
cloudSync
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: rnewman, Assigned: ack)

Tracking

(Depends on: 2 bugs)

unspecified
mozilla35
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox32 unaffected, firefox33 unaffected, firefox34+ fixed, firefox35 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8471333 [details] [diff] [review]
enable_cloudsync.patch
Assignee: nobody → akligman
Status: NEW → ASSIGNED
Attachment #8471333 - Flags: review?(rnewman)
(Reporter)

Comment 2

4 years ago
Comment on attachment 8471333 [details] [diff] [review]
enable_cloudsync.patch

Over to a build peer.
Attachment #8471333 - Flags: review?(rnewman) → review?(gps)

Comment 3

4 years ago
Comment on attachment 8471333 [details] [diff] [review]
enable_cloudsync.patch

Review of attachment 8471333 [details] [diff] [review]:
-----------------------------------------------------------------

The patch is technically sound.

But r+ for enabling features is typically deferred to someone with knowledge of the feature and its implications. I know nothing about this feature and don't feel comfortable giving it a green light.
Attachment #8471333 - Flags: review?(gps) → feedback+
(Assignee)

Comment 4

4 years ago
Created attachment 8481448 [details] [diff] [review]
0001-Bug-1052009-Enable-CloudSync-in-Nightly.patch

Land before B#993584.
Attachment #8471333 - Attachment is obsolete: true
Attachment #8481448 - Flags: review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Can we get a Try run for this and the other cloudsync bugs?
Flags: needinfo?(akligman)
Keywords: checkin-needed
(Reporter)

Comment 6

4 years ago
This should not be checked in until all dependencies have landed. That's why it's a separate bug.
Whiteboard: [do not land until dependencies land]
(Assignee)

Comment 7

4 years ago
https://tbpl.mozilla.org/?tree=Try&rev=f0128f81350f
Flags: needinfo?(akligman)
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Hi Alan, so is this now ready to land ? Bug 993584 landed but the other dependency bugs here are open ?
Flags: needinfo?(akligman)
Keywords: checkin-needed
(Assignee)

Comment 9

4 years ago
I'm investigating the tbpl failures you reported.
Flags: needinfo?(akligman)
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
(Assignee)

Comment 10

4 years ago
Note: this should land after 1045046.
https://hg.mozilla.org/integration/fx-team/rev/4476fca7e5fe
Keywords: checkin-needed
Whiteboard: [do not land until dependencies land] → [do not land until dependencies land][fixed-in-fx-team]
sorry had to backout this change in https://tbpl.mozilla.org/?tree=Fx-Team&rev=1951712e6147 since one of this checkins seems to have caused https://tbpl.mozilla.org/php/getParsedLog.php?id=47669697&tree=Fx-Team
Whiteboard: [do not land until dependencies land][fixed-in-fx-team] → [do not land until dependencies land]
(Assignee)

Comment 13

4 years ago
This enables cloudsync and causes new tests to run. I'm not seeing this failure in the other test runs I did. Investigating.
(Assignee)

Comment 14

4 years ago
Created attachment 8487513 [details] [diff] [review]
0002-Bug-1052009-Enable-CloudSync-in-Nightly.patch
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Whiteboard: [do not land until dependencies land]
https://hg.mozilla.org/integration/fx-team/rev/f980055c8339
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/f980055c8339
https://hg.mozilla.org/mozilla-central/rev/582c6bff081d
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 35
(Reporter)

Updated

4 years ago
Component: Sync → cloudSync
Product: Firefox → Mozilla Services
Target Milestone: Firefox 35 → ---
Version: Trunk → unspecified
(Assignee)

Comment 19

4 years ago
Comment on attachment 8481448 [details] [diff] [review]
0001-Bug-1052009-Enable-CloudSync-in-Nightly.patch

This enables the service in bug#993584.

Approval Request Comment
[Feature/regressing bug #]: n/a
[User impact if declined]: For a partner project that we have committed to delivering in 34
[Describe test coverage new/current, TBPL]:Basic test coverage for API, some mochitest coverage for UI events
[Risks and why]: Low impact, mostly new code; Unlikely to receive any input from our pre-release user populations as this requires a separate add-on that is not yet ready
[String/UUID change made/needed]: No string changes
Attachment #8481448 - Flags: approval-mozilla-aurora?
status-firefox32: --- → unaffected
status-firefox33: --- → unaffected
status-firefox34: --- → affected
status-firefox35: --- → fixed
tracking-firefox34: --- → +
Comment on attachment 8481448 [details] [diff] [review]
0001-Bug-1052009-Enable-CloudSync-in-Nightly.patch

I've spoken with Alan about this feature and the need to ship it in 34. Aurora+
Attachment #8481448 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/3c832ff5ea5b
status-firefox34: affected → fixed
Flags: in-testsuite+
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.