Closed
Bug 1052026
Opened 10 years ago
Closed 10 years ago
Missing contentDescription on menu item between Bookmark and Share
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 34
People
(Reporter: MarcoZ, Assigned: ramasamy.zephyr, Mentored)
Details
(Keywords: access, Whiteboard: [lang=java])
Attachments
(1 file, 1 obsolete file)
2.79 KB,
patch
|
Details | Diff | Splinter Review |
There seems to be a new menu item which is missing a contentDescription, right between the Bookmark and Share items on the menu when opened on a Nexus 5. 1. Launch Fennec Nightly on a Nexus 5 running KitKat. 2. Load a page. 3. Open the menu. 4. Between the Bookmark and Share items, there is another item which TalkBack only announces as "Graphic" plus some number. Trivial fix: Add a localized contentDescription describing what this thing is.
Comment 1•10 years ago
|
||
This is probably one or two quick share items that will appear after you initially share
Reporter | ||
Comment 2•10 years ago
|
||
(In reply to Aaron Train [:aaronmt] from comment #1) > This is probably one or two quick share items that will appear after you > initially share Interesting! Then the contentDescription should be the name of the share target that's being offered. :)
Updated•10 years ago
|
Mentor: wjohnston
Whiteboard: [lang=java]
Comment 3•10 years ago
|
||
We add those here: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/widget/GeckoActionProvider.java#107 but we only pass an icon there! We should probably modify that method to take a string as well: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/menu/MenuItemActionView.java#138 i.e. you should never be creating an action view that has no text for the contentDescription.
Assignee | ||
Comment 4•10 years ago
|
||
I tested in Nexus 5 and seems to work fine.
Attachment #8474271 -
Flags: review?(wjohnston)
Comment 5•10 years ago
|
||
Comment on attachment 8474271 [details] [diff] [review] Bug_1052026_Add_contentDescription_To_ActionButton.patch Review of attachment 8474271 [details] [diff] [review]: ----------------------------------------------------------------- Nice :) And thanks. One little nit. Can you upload a fixed patch and mark checkin-needed :) https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F ::: mobile/android/base/widget/GeckoActionProvider.java @@ +104,5 @@ > return view; > } > > for (int i = 0; i < historySize; i++) { > + view.addActionButton(dataModel.getActivity(i).loadIcon(packageManager),dataModel.getActivity(i).loadLabel(packageManager)); space after the comma. I'd probably put the second argument on a new line and line it up with the argument above too. It makes it easier to parse the two arguments.
Attachment #8474271 -
Flags: review?(wjohnston) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Thanks for reviewing.
Attachment #8474766 -
Flags: checkin?(wjohnston)
Comment 7•10 years ago
|
||
Comment on attachment 8474766 [details] [diff] [review] Bug_1052026_Fix.patch Can we get a Try run first please? :) Also, you can just set the checkin-needed bug keyword when your patch is ready to land.
Attachment #8474766 -
Flags: checkin?(wjohnston)
Updated•10 years ago
|
Assignee: nobody → ramasamy.zephyr
Updated•10 years ago
|
Attachment #8474271 -
Attachment is obsolete: true
Assignee | ||
Comment 8•10 years ago
|
||
I don't have level-1 access to do a try run.
Comment 10•10 years ago
|
||
Try builds green, ran the Android performance tests. Java only change so building other platforms is a waste of CPU.
Keywords: checkin-needed
Comment 11•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/5be7f9b2bef3
Keywords: checkin-needed
Whiteboard: [lang=java] → [lang=java][fixed-in-fx-team]
Comment 12•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5be7f9b2bef3
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [lang=java][fixed-in-fx-team] → [lang=java]
Target Milestone: --- → Firefox 34
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•