1052028 - Remove "Node" from displayed node names

Status: RESOLVED FIXED

(DevTools Graveyard :: Web Audio Editor, defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

This is redundant, as all nodes have "Node" at the end, "OscillatorNode", "GainNode", etc.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1052028-change-node-rendering.patch

Quick and easy patch.

Comment 2

[Victor Porof [:vporof][:vp]]

Comment on attachment 8472486 [details] [diff] [review]
1052028-change-node-rendering.patch

Review of attachment 8472486 [details] [diff] [review]:
-----------------------------------------------------------------

Tests still pass?

::: browser/devtools/webaudioeditor/webaudioeditor-view.js
@@ +158,5 @@
>        // Add node to graph
> +      graph.addNode(node.id, {
> +        type: node.type,                        // Just for storing type data
> +        label: node.type.replace(/Node$/, ""),  // Displayed in SVG node
> +        id: node.id                             // Identification 

Nit: trailing whitespace.

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1052028-change-node-rendering.patch

whitespace fixed

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

All tests passing locally, try down, will push when clear and get checkin.

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

try: https://tbpl.mozilla.org/?tree=Try&rev=28620b6ae838

Comment 6

[Jordan Santell [:jsantell] [@jsantell]]

praying that try is working now https://tbpl.mozilla.org/?tree=Try&rev=bc9e2792f63a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/abd2919b124b

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/abd2919b124b