Closed Bug 1052212 Opened 11 years ago Closed 11 years ago

[B2G][Loop] "Delete" button within "Clean all Calls" confirmation menu is not a red button

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Loop
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(b2g-v2.0 affected, b2g-v2.1 affected)

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
b2g-v2.0 --- affected
b2g-v2.1 --- affected

People

(Reporter: jdegeus, Assigned: arnau)

References

Details

(Whiteboard: [mobile app][not blocking][2.0-exploratory][tef-triage][patch available])

Attachments

(2 files)

Non_red.png
208.01 KB, image/png
Details
patch in github
61 bytes, text/x-github-pull-request
borjasalguero
: review+
Details | Review
Attached image Non_red.png —
Description: When users elect to "Clean all Calls" from the Settings menu, the confirmation menu that appears contains two buttons; "Delete" and "Cancel". The "Delete" button displays with a grey background rather than red. Setup: - Install the Loop app on a device from: https://github.com/mozilla-b2g/firefoxos-loop-client Repro Steps: 1) Update a Flame to 20140811000210 2) Launch Loop app 3) Select Settings> Clean all Calls 4) Observe confirmation menu contains a "Delete" button that is not red Actual: "Delete" button within "Clean all Calls" confirmation menu is not dispalying as a red button Expected: "Delete" button displays red Environmental Variables: Device: Flame 2.0 Build ID: 20140811000210 Gaia: de28796a8956a48bb98ca67df6a33e0622d642d1 Gecko: 5256345f62bd Version: 32.0 (2.0) Firmware Version: v123 User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0 Repro frequency: 3/3 See attached: Screenshot and logcat attached
This issue DOES OCCUR on Flame 2.1 (319mb) , Flame 2.0 (512mb) and Buri 2.1, Buri 2.0 Actual: Users will receive error message stating "Unable to retrieve link to share" with no active connection. Flame 2.1 (319mb) Environmental Variables: Device: Flame Master Build ID: 20140811040202 Gaia: 19ed3c9e78eaf234cc08484bde6998ae21552ba5 Gecko: a9b43778f0c2 Version: 34.0a1 (Master) Firmware Version: v123 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0 Flame 2.0 (512mb) Enviromental Variables: Device: Flame 2.0 BuildID: 20140811000210 Gaia: de28796a8956a48bb98ca67df6a33e0622d642d1 Gecko: 5256345f62bd Version: 32.0 (2.0) Firmware: V123 User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0 Buri 2.1 Environmental Variables: Device: Buri Master Build ID: 20140811013006 Gaia: 19ed3c9e78eaf234cc08484bde6998ae21552ba5 Gecko: a9b43778f0c2 Version: 34.0a1 (Master) Firmware Version: v1.2device.cfg User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0 Buri 2.0 Environmental Variables: Device: Buri 2.0 Build ID: 20140811063003 Gaia: 9f94a78eef3a9305140c550c983871a46b0692e7 Gecko: c2636750a6a1 Version: 32.0 (2.0) Firmware Version: v1.2device.cfg User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0 ----------------------------------------------------------- Loop app is currently not supported on 1.4 Flame 1.4 (319mb) Environmental Variables: Device: Flame 1.4 Build ID: 20140811063003 Gaia: 4a662f6dd831cf6194d7ad3501b1d56ea2964a20 Gecko: c12f198b5e51 Version: 30.0 (1.4) Firmware Version: v123 User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0 Buri 1.4 Environmental Variables: Device: Buri 1.4 Build ID: 20140811000206 Gaia: 4a662f6dd831cf6194d7ad3501b1d56ea2964a20 Gecko: e1b03b2fb92e Version: 30.0 (1.4) Firmware Version: v1.2device.cfg User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Actual: Users will receive error message stating "Unable to retrieve link to share" with no active connection? Please double check your branch checks and fix this.
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage-]
Flags: needinfo?(ktucker) → needinfo?(jdegeus)
My apologies for this. Branch checks are still valid, was a copy/paste fail. Actual: The "Delete" button within "Clean all Calls" confirmation menu is not red
QA Whiteboard: [QAnalyst-Triage-] → [QAnalyst-Triage?]
Flags: needinfo?(jdegeus) → needinfo?(ktucker)
Minor issue but should be consistent with the rest of the OS. Not nominating as a blocker.
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Loop Version: 609ec57
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage+][lead-review+]
Whiteboard: [2.0-exploratory] → [2.0-exploratory][not blocking]
Whiteboard: [2.0-exploratory][not blocking] → [loop mobile][not blocking]
Whiteboard: [loop mobile][not blocking] → [mobile app][not blocking]
Whiteboard: [mobile app][not blocking] → [mobile app][not blocking][2.0-exploratory]
Arnau, can you handle this?
Severity: normal → minor
Flags: needinfo?(rnowmrch)
Whiteboard: [mobile app][not blocking][2.0-exploratory] → [mobile app][not blocking][2.0-exploratory][tef-triage]
Assignee: nobody → rnowmrch
Flags: needinfo?(rnowmrch)
Attached file patch in github —
Attachment #8492121 - Flags: review?(borja.bugzilla)
Status: NEW → ASSIGNED
Whiteboard: [mobile app][not blocking][2.0-exploratory][tef-triage] → [mobile app][not blocking][2.0-exploratory][tef-triage][patch available]
Comment on attachment 8492121 [details] [review] patch in github R+! Rebase & Recheck before landing. Thanks!
Attachment #8492121 - Flags: review?(borja.bugzilla) → review+
Rebased and tested! Merged: 693dd7e8ba6308138d66f53e0b5bdf19517cfec5
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Tested with Gecko-675810c.Gaia-092d2b7 and Loop v. d159db7 and works fine
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: