Disable leak checking in content processes

RESOLVED FIXED in mozilla34

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: billm, Assigned: mccr8)

Tracking

unspecified
mozilla34
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

On desktop, the content process pretty much always crashes before it gets a chance to report leaks. If we fix the crash, then leaks appear. It seems most reasonable to disable content process leak checking, fix the crashes, and eventually fix the leaks and re-enable.

Kyle, what effect will that have on your b2g work?
Flags: needinfo?(khuey)
None, yet.  Go ahead and do this.
Flags: needinfo?(khuey)
(Assignee)

Updated

4 years ago
See Also: → bug 1051230
(Assignee)

Updated

4 years ago
Assignee: nobody → continuation
(Assignee)

Updated

4 years ago
Blocks: 1035454
(Assignee)

Comment 2

4 years ago
Created attachment 8477089 [details] [diff] [review]
Disable leak checking in content processes.

try: https://tbpl.mozilla.org/?tree=Try&rev=0ff144b4e0d8
(Assignee)

Updated

4 years ago
Component: DOM: Content Processes → Mochitest
OS: Linux → All
Product: Core → Testing
Hardware: x86_64 → All
(Assignee)

Comment 3

4 years ago
Comment on attachment 8477089 [details] [diff] [review]
Disable leak checking in content processes.

try run: https://tbpl.mozilla.org/?tree=Try&rev=0ff144b4e0d8

I'm pretty sure the M3 orange is from the other patch in that stack, as it is a shutdown assertion.
Attachment #8477089 - Flags: review?(jmaher)
Comment on attachment 8477089 [details] [diff] [review]
Disable leak checking in content processes.

Review of attachment 8477089 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/automationutils.py
@@ +353,5 @@
>      return
>  
>    # totalBytesLeaked was seen and is non-zero.
> +  # For now, ignore tab process leaks. See bug 1051230.
> +  if (totalBytesLeaked > leakThreshold) and (not processType or processType != "tab"):

so we will still get a warning printed.  Can we somehow indicate in the log file in the else condition below that we are ignoring this as it is a tab process?
Attachment #8477089 - Flags: review?(jmaher) → review-
(Assignee)

Comment 5

4 years ago
Created attachment 8477518 [details] [diff] [review]
Disable leak checking in content processes.

Yeah, that's probably a good idea.
Attachment #8477089 - Attachment is obsolete: true
Attachment #8477518 - Flags: review?(jmaher)
Comment on attachment 8477518 [details] [diff] [review]
Disable leak checking in content processes.

Review of attachment 8477518 [details] [diff] [review]:
-----------------------------------------------------------------

thanks, that looks much better!
Attachment #8477518 - Flags: review?(jmaher) → review+
https://hg.mozilla.org/mozilla-central/rev/f8ac66a28f2f
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.