1052264 - Disconnecting from sync resets choice of what datatypes to sync

Status: RESOLVED WORKSFORME

(Firefox :: Sync, defect, P1)

Description

[Ryan Kelly [:rfkelly]]

(Some non-obvious UI reported by a user in IRC)

Steps to reproduce:

* set up sync by logging in with a firefox account
* deselect e.g. "history" from being synced
* disconnect from sync
* re-connect by logging in again with your firefox account

The selection of what datatypes to sync will have been reset to its defaults, so that e.g. "history" is once again selected for syncing.

I'm not sure this is actually a bug, but at least one user on IRC found it unintuitive and was expecting the datatype selection to persist across the logout/login dance.

(Semi-related to the "how much state should we reset on logout" question posed by Bug 1003708)

Comment 1

[Chris Karlof [:ckarlof]]

Hmm. This shouldn't actually happen, because I think your selections should be re-discovered after you log back in (from the Sync server). 

Next action here is to try to reproduce this.

These preferences are lost after password reset, though. (Bug 1100813)

Comment 2

[Edwin Wong [:edwong]]

Karl - can you attempt to repro?

Comment 3

[Karl Thiessen [:kthiessen, he/him]]

Sure, I'll take a look at this tomorrow morning.

Comment 4

[Karl Thiessen [:kthiessen, he/him]]

Yes, this bug reproduces on current Nightly (2015-08-26).  Might be nice to have an estimate of how long after the settings change one should wait before disconnecting the account, to make sure the settings are persisted -- the Sync preferences pane no longer has an explicit save button.  But certainly if I disconnect the account less than a minute after changing these settings, they revert to the defaults on next login.

Let me know if you want me to do more detailed checks.

Comment 5

[Chris Karlof [:ckarlof]]

I can't reproduce, as long as I make sure the elections are synced before I disconnect. You can manually do this with the "Sync Now" option in the Tools menu. I did a "Sync Now", a logout, and then logged back in, and I saw that my datatype elections were preserved. 

If the user logs out so quickly after setting her preferences that they haven't been synced yet, and then logs back in, I'm not really sure what they're trying to accomplish there.

I'm closing as WORKSFORME, but Karl if you can reproduce after making sure the elections are synced before disconnecting, please re-open.