1052370 - [Dialer][Emergency call] Duplicate phone number when typing number

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Jorge Prudencio [:jorgep]]

Attachment: [bug] Duplicated-number.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0 (Beta/Release)
Build ID: 20140715214327

Steps to reproduce:

1. Go to Settings > Screen Lock > Passcode lock and introduce a Screen Lock passcode.
2. Lock the mobile and unlock it.
3. Push "Emergency Call".
4. Insert a phone number.


Actual results:

Behind of the delete number icon appears the number that we are introducing. 


Expected results:

The number shouldn't appear duplicated.

Comment 1

[Jorge Prudencio [:jorgep]]

Attachment: [bug] Duplicated-number-long-number.png

Comment 2

[Jorge Prudencio [:jorgep]]

Attachment: [bug] Duplicated-number-very-long-number.png

Comment 3

[Jason Smith [:jsmith]]

QA Wanted for branch checks.

Comment 4

[Cody Roesch [:croesch]]

This bug repro's on: Flame 2.1, Buri 2.1

Actual Results: Typing numbers into the emergency dialer screen causes numbers to be seen under the delete button.

Repro Rate: 5/5

Environmental Variables:
Device: Flame Master
BuildID: 20140811230755
Gaia: e78e62125eb43c3a28cdc047987ba54430694a2f
Gecko: b53c2753ce9a
Version: 34.0a1 (Master) 
Firmware Version: v123
------------------------------------------------
Environmental Variables:
Device: Buri Master
BuildID: 20140812090644
Gaia: 02f778766521b84da0ca3e575bfe35c37f46803d
Gecko: c359b1a03ba2
Version: 34.0a1 (Master) 
Firmware Version: v1.2device.cfg

------------------------------------------------
------------------------------------------------

This bug does NOT repro on: Flame 2.0, Flame 1.4

Actual Result: No issues seen when typing numbers into the emergency dialer screen.

Repro Rate: 0/5 attempts

Environmental Variables:
Device: Flame 2.0
BuildID: 20140812003057
Gaia: 88e774c606520c9ce349b467866e200e8db31af4
Gecko: d37b1bd92b3d
Version: 32.0 (2.0) 
Firmware Version: v123
------------------------------------------------
Environmental Variables:
Device: Flame 1.4
BuildID: 20140811081112
Gaia: d47fecdcaa4aefb754561114edd22fb23a92b98d
Gecko: fbee340d0830
Version: 30.0 (1.4) 
Firmware Version: v123

Comment 5

[Joshua Mitchell (Inactive)]

Qa-Triage - bug is a regression but not along a critical-user-path (Emergency Call) - would not nom unless bad visuals with emergency calls is a cert issue?

Comment 6

[Francesco Lodolo [:flod]]

My guess is bug 967440, removing this rule from keypad.css

#fake-phone-number-view {
 position: absolute;
 left: 2rem;
 line-height: 0;
 visibility: hidden;
}

Comment 7

[Germán Toro del Valle (:gtorodelvalle)]

Yeah, I +1 Francesco's comment 6 ;)

Comment 8

[Jorge Prudencio [:jorgep]]

Attachment: 22826.html

Comment 9

[Anthony Ricaud (:rik)]

Comment on attachment 8472188 [details]
22826.html

The proper fix for this is to migrate the emergency call to use FontSizeManager too. Can you open a follow-up bug?

Comment 10

[Doug Sherk (:drs) (inactive)]

https://github.com/mozilla-b2g/gaia/commit/7551fc09fe1b05dde5175baf49a7a120f828dedf

See comment 9.

Comment 11

[Germán Toro del Valle (:gtorodelvalle)]

(In reply to Anthony Ricaud (:rik) from comment #9)
> Comment on attachment 8472188 [details]
> 22826.html
> 
> The proper fix for this is to migrate the emergency call to use
> FontSizeManager too. Can you open a follow-up bug?

Hi Anthony,

Yeah, I talked about that with Jorge and we decided that that change would be inherited as a consequence of the keypad.js library refactoring needed for the Dialer, Call Screen and Emergency Call apps. In fact, I have just created bug 1053922 for this.

Do you still want to create that follow-up bug as a first step before the keypad.js refactoring or shall we do it directly in bug 1053922? :)

Thanks!

Comment 12

[Anthony Ricaud (:rik)]

Bug 1053922 is fine for this, thanks!