1052469 - [email] Update signature default to use proper brand

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[James Burke [:jrburke]]

As :flod points out in bug 847168 comment 37, we should change 'FirefoxOS' to 'Firefox OS' for the default signature string. We just do this for the en-US locale.

This is a 2.1-only issue as the Signature code just landed in master.

Comment 1

[Alex Wissmann [:awiss]]

Attachment: Patch

Comment 2

[Francesco Lodolo [:flod]]

Technically, you need to change the string ID (I know, I'm a PITA).

Comment 3

[James Burke [:jrburke]]

:flod, I was under the impression we only change the string ID if we change how it is used, and not for fixing a typo in the existing en-US string? Or is the concern in this case that since it mentions branding, other localizations of the string are incorrectly using FirefoxOS now?

Comment 4

[Francesco Lodolo [:flod]]

We don't change the string ID when we fix typos, but I'm not sure this can be considered a typo. 

For sure we don't want other locales to use "FirefoxOS", and using a new ID is the only way to make sure of that.

Comment 5

[James Burke [:jrburke]]

Comment on attachment 8471714 [details] [review]
Patch

:flod, thanks for the clarification. We updated the string ID, and landed in gaia master:
https://github.com/mozilla-b2g/gaia/commit/8ec3fe5fc780bb56a8a618c086fc700bbcf18b3d

from pull request:
https://github.com/mozilla-b2g/gaia/pull/22790

Comment 6

[Francesco Lodolo [:flod]]

Thanks :-)