1052513 - Selection offsets broken on descendant accessibles

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[James Teh [:Jamie]]

Str:
1. Open this: data:text/html,a<div>b</div>
2. Press control+a to select all.
3. Get the accessible for the document.
4. Call IAccessibleText::selection(0).
Result (correct): (0, 2)
5. Get the accessible for the div.
6. Call IAccessibleText::selection(0).
Expected: (0, 1)
Actual: (1, 1)

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: fix HyperTextAccessible::SelectionBoundsAt for selections extending outside the current hyper text

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 8472656 [details] [diff] [review]
fix HyperTextAccessible::SelectionBoundsAt for selections extending outside the current hyper text

Review of attachment 8472656 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/generic/HyperTextAccessible.cpp
@@ +1451,5 @@
> +
> +  if (!nsContentUtils::ContentIsDescendantOf(endNode, mContent))
> +    *aEndOffset = CharacterCount();
> +  else
> +    *aEndOffset = DOMPointToOffset(endNode, endOffset, true);

does it work when both points either after or before the text accessible? it'd be good to have a test case for it

::: accessible/tests/mochitest/textselection/test_general.html
@@ +182,5 @@
>        gQueue.push(new synthFocus("textarea", onfocusEventSeq("textarea")));
>        gQueue.push(new changeSelection("textarea", 1, 3));
>  
> +      gQueue.push(new changeDOMSelection("c1", "c1_span1", 0, "c1_span2", 0, [["c1", 2, 2]]));
> +      gQueue.push(new changeDOMSelection("c2", "c2", 0, "c2_div2", 1, [["c2", 0, 3], ["c2_div2", 0, 2]]));

nit: it'd be good to break this into two lines

::: testing/mochitest/runtests.py
@@ -1158,5 @@
>      gmp_path = os.path.join(self.profile.profile, 'plugins', 'gmp-fake')
>      if os.path.isdir(gmp_path):
>        return gmp_path
>      # This is fatal for desktop environments.
> -    raise EnvironmentError('Could not find gmp-fake')

unrelated

::: testing/testsuite-targets.mk
@@ +38,5 @@
>  RUN_MOCHITEST = \
>    rm -f ./$@.log && \
>    $(PYTHON) _tests/testing/mochitest/runtests.py --autorun --close-when-done \
>      --console-level=INFO --log-file=./$@.log --file-level=INFO \
> +    --log-tbpl --failure-file=$(abspath _tests/testing/mochitest/makefailures.json) \

unrelated

Comment 3

[alexander :surkov (:asurkov)]

Trev, ping

Comment 4

[Trevor Saunders (:tbsaunde)]

> ::: accessible/generic/HyperTextAccessible.cpp
> @@ +1451,5 @@
> > +
> > +  if (!nsContentUtils::ContentIsDescendantOf(endNode, mContent))
> > +    *aEndOffset = CharacterCount();
> > +  else
> > +    *aEndOffset = DOMPointToOffset(endNode, endOffset, true);
> 
> does it work when both points either after or before the text accessible?

GetSelectionDOMRanges() doesn't return ranges that don't intersect the subtree of GetNode()

> it'd be good to have a test case for it

I guess it can't hurt.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ff17b837114d