1052536 - configure: line 16243: MOZ_FMP4: command not found

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ed Morley [:emorley]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=45748738&tree=B2g-Inbound

04:26:05     INFO -   0:16.66 checking for localeconv... yes
04:26:05     INFO -   0:16.68 checking NSPR selection... source-tree
04:26:05     INFO -   0:16.68 checking for YASM assembler... checking for yasm... yasm
04:26:05    ERROR -   0:16.69 /builds/slave/l64-br-haz_b2g-in_dep-00000000/build/source/configure: line 16243: MOZ_FMP4: command not found
04:26:05     INFO -   0:16.70 checking for application to build... browser


Believe from:
http://mxr.mozilla.org/mozilla-central/source/configure.in#3779
3779 if test -n "$MOZ_FMP4"; then
3780   MOZ_FMP4=1
3781 else
3782   MOZ_FMP4 =
3783 fi

Guess from the additional space before the equals?

Comment 1

[Blake Wu [:bwu][:blakewu]]

Hi Ed, 
Thanks for your information!
I will remove that space and have a try again.

Comment 2

[Blake Wu [:bwu][:blakewu]]

Attachment: Bug-1052536-Remove-unnecessary-space.patch

TBPL: https://tbpl.mozilla.org/?tree=Try&rev=44b20e85f3de

Comment 3

[Blake Wu [:bwu][:blakewu]]

Comment on attachment 8472052 [details] [diff] [review]
Bug-1052536-Remove-unnecessary-space.patch

Hi Mike, 
All building results on are good on https://tbpl.mozilla.org/?tree=Try&rev=44b20e85f3de. 
Could you please help review the codes?
Thanks!

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bb34bb0670eb

I fixed up the commit message to follow the usual guidelines. Please try to keep in mind for the future that the commit message should be saying what the patch is doing, not restating the problem it's fixing. Thanks :)
https://developer.mozilla.org/en-US/docs/Developer_Guide/Committing_Rules_and_Responsibilities#Checkin_comment

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bb34bb0670eb

Comment 6

[Blake Wu [:bwu][:blakewu]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #4)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/bb34bb0670eb
> 
> I fixed up the commit message to follow the usual guidelines. Please try to
> keep in mind for the future that the commit message should be saying what
> the patch is doing, not restating the problem it's fixing. Thanks :)
> https://developer.mozilla.org/en-US/docs/Developer_Guide/
> Committing_Rules_and_Responsibilities#Checkin_comment
Opps. Sorry! I forgot it. 
Thanks for your help and tip! I will keep it in mind.