1052557 - [Settings] Stuck in sim-security panel

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Wilson Page [:wilsonpage]]

[flame] - With single SIM card inserted

STEPS:

1. Open settings
2. Tap 'SIM Manager'
3. Tap 'SIM Security'
4. Attempt to tap 'Back' or 'Change PIN'

ACTUAL: App becomes unresponsive
EXPECTED: App should navigate to chosen location

Comment 1

[Arthur Chen [:arthurcc][inactive after 6/30]]

This was regressed by https://github.com/mozilla-b2g/gaia/commit/b564a726e0c95fe105c3a9a3fd0a549f66b60647. I will take a look at the issue.

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: link to https://github.com/mozilla-b2g/gaia/pull/22811

EJ, as we discussed, could you help review the patch? Thanks.

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8472037 [details]
link to https://github.com/mozilla-b2g/gaia/pull/22811

Thanks Arthur !

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks!

master: 2864a8d4413746a5359bbcc5042ef776ed06009a

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

[Blocking Requested - why for this release]: The patch solves a v2.0 blocker.

Comment 6

[howie [:howie]]

2.0 + based on Comment 5

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8472037 [details]
link to https://github.com/mozilla-b2g/gaia/pull/22811

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): N/A
[User impact] if declined: Users are not able to back to the previous panel sometimes.
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: N/A

Comment 8

[Ryan VanderMeulen [:RyanVM]]

2.0 blockers don't need approval.

v2.0: https://github.com/mozilla-b2g/gaia/commit/c48e9cb386aadf4c10811eb1d06e681d3465a914

Comment 9

[Lancy(Leave from Mozilla)]

Attachment: Verify_Video_Flame.MP4

This issue has been verified successfully on Flame 2.0 & 2.1.
See attachment: Verify_Video_Flame.MP4
Reproducing rate: 0/30

Flame v2.0 version:
Gaia-Rev        f9d6e3d83c3922e9399a6c27f5ce4cdd27bdfd05
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/45112935086f
Build-ID        20141126000203
Version         32.0

Flame v2.1 version:
Gaia-Rev        db2e84860f5a7cc334464618c6ea9e92ff82e9dd
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/211eae88f119
Build-ID        20141126001202
Version         34.0