1052775 - test_call_start_from_end_handler.html is logging results after SimpleTest.finish()

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Martijn Wargers (dead)]

This is a spin-off from bug 1032878. In that bug, I basically try to fix all tests that were still logging subresults after SimpleTest.finish() was called.

I tried to fix this test in that bug, but my fix caused leaks. This is the patch that seemed to cause leaks: https://bug1032878.bugzilla.mozilla.org/attachment.cgi?id=8470599
I don't think that should cause leaks, should it?

Comment 1

[Martijn Wargers (dead)]

Attachment: 1052775.diff

This is a patch that seems to fix this issue and not cause any leaks.
But this setTimeout call is really weird.

Comment 2

[Martijn Wargers (dead)]

Guilherme, could you help me fix this issue. Perhaps, there is another way to fix this.
I guess, ideally, the leak issue should be fixed.

Comment 3

[Guilherme Gonçalves [:ggp]]

Attachment: WIP

I believe you have exposed some deeper flaws in SpeechRecognition; sorry about that.
I'll have to take a deeper look later, but meanwhile, can you check whether this patch
fixes your initial problem, and that it doesn't leak?

Comment 4

[Martijn Wargers (dead)]

Attachment: 1052775.diff

Yes, that seems to fix the problem and doesn't leak, thanks!

Comment 5

[Guilherme Gonçalves [:ggp]]

Filed bug 1055093 for what I believe to be the underlying issue here. I'll have a patch shortly.

Comment 6

[Guilherme Gonçalves [:ggp]]

Attachment: Abort speech recognition after test_call_start_from_end_handler

Comment 7

[Guilherme Gonçalves [:ggp]]

Attachment: Abort speech recognition after test_call_start_from_end_handler

Comment 8

[Guilherme Gonçalves [:ggp]]

Try is looking good: https://tbpl.mozilla.org/?tree=Try&rev=5f6250ca8856

However, I don't see any of our logging messages at all in the logs. Martjin, is this expected? Just want to make sure the problem is fixed, and if it is, we should be clear to land :)

Comment 9

[Guilherme Gonçalves [:ggp]]

Sorry, no checkin-needed for now.

Comment 10

[Martijn Wargers (dead)]

(In reply to Guilherme Gonçalves [:ggp] from comment #8)
> Try is looking good: https://tbpl.mozilla.org/?tree=Try&rev=5f6250ca8856
> 
> However, I don't see any of our logging messages at all in the logs.
> Martjin, is this expected? Just want to make sure the problem is fixed, and
> if it is, we should be clear to land :)

This had to be tested in combination with the patch: https://bug1032878.bugzilla.mozilla.org/attachment.cgi?id=8467931 (patch  1032878_v4.diff from bug 1032878) to make sure that it didn't cause failures.
I just did that and it seems fine and I don't see any leaks with it.
Thanks for your help!

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1e3273854ca7

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1e3273854ca7