1052909 - Remove pref and code that enables websocket redirects

Status: RESOLVED FIXED

(Core :: Networking: WebSockets, task, P3)

Description

[Tanvi Vyas[:tanvi]]

network.websocket.auto-follow-http-redirect is set to false by default.  A search through the addon mxr doesn't highlight any addons that set this pref to true:
https://mxr.mozilla.org/addons/search?string=auto-follow-http-redirects

We should remove this preference and remove the code that handles websocket redirects.

Except - we should keep the code that allows for websockets to be upgraded from ws:// to wss://.
http://mxr.mozilla.org/mozilla-central/source/netwerk/protocol/websocket/WebSocketChannel.cpp#2478

Comment 1

[Jason Duell]

Patrick:

Got any objections to removing support for websocket redirects?  The simplest patch would be to remove the pref but keep the existing code in place (i.e. still have mAutoFollowRedirects, but always keep it == 0) in case we want to support redirects again someday.

Also we're not talking about changing the special case that allows redirecting from ws: -> wss: during HTTPS-everywhere.

Comment 2

[Patrick McManus [:mcmanus]]

that code can all be removed - it was written like that when it wasn't clear which way the RFC would go.

Comment 3

[Tanvi Vyas[:tanvi]]

Anyone want to take this bug?

Comment 4

[Tanvi Vyas[:tanvi]]

(In reply to Tanvi Vyas [:tanvi] from comment #3)
> Anyone want to take this bug?

Perhaps jduell can find an owner?

Comment 5

[Jason Duell]

It's on my list of smallish/less-important bugs to fix.

Comment 6

[Tanvi Vyas[:tanvi]]

Any update on removing this code?

Comment 7

[Steve Workman [:sworkman] (INACTIVE)]

At Tanvi's request, I will take this one :)

Comment 8

[Steve Workman [:sworkman] (INACTIVE)]

Needinfo'ing myself as a reminder.

Comment 9

[Patrick McManus [:mcmanus]]

steve?

Comment 10

[Steve Workman [:sworkman] (INACTIVE)]

Yeah ... unlikely that I'll get to this, especially considering that it's been in my queue for a year. Unassigning myself...

Comment 11

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 12

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 13

[Gregory Pappas [:gregp]]

Attachment: Bug 1052909 - Remove network.websocket.auto-follow-http-redirects pref r?#necko!

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/599dc5d67521
Remove network.websocket.auto-follow-http-redirects pref r=necko-reviewers,kershaw

Comment 15

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/599dc5d67521