Closed
Bug 1052913
Opened 11 years ago
Closed 11 years ago
Clean up the naming of some nsSVGClipPathFrame code to make it clearer
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: jwatt, Assigned: jwatt)
Details
Attachments
(1 file)
|
10.76 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8471965 -
Flags: review?(dholbert)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8471965 [details] [diff] [review]
patch
>--- a/layout/svg/nsSVGClipPathFrame.h
>- nsIFrame *mClipParent;
>+ nsIFrame *mClippedFrame;
> nsAutoPtr<gfxMatrix> mClipParentMatrix;
I was going to comment that mClipParentMatrix's name is now a bit stale (since mClipParent has been renamed), but it looks like that matrix is going away in bug 1052915 anyway.
So, r=me
Attachment #8471965 -
Flags: review?(dholbert) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e8127cc0e8a0
I changed the name again to something more accurate, and will probably split this function shortly.
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
|
||
Updated•11 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•