Closed Bug 1052913 Opened 7 years ago Closed 7 years ago

Clean up the naming of some nsSVGClipPathFrame code to make it clearer

Categories

(Core :: SVG, defect)

Product:
Core
Component:
SVG
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla34

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(1 file)

patch
10.76 KB, patch
dholbert
: review+
Details | Diff | Splinter Review 
No description provided.
Attached patch patch — — Splinter Review
Attachment #8471965 - Flags: review?(dholbert)
Comment on attachment 8471965 [details] [diff] [review]
patch

>--- a/layout/svg/nsSVGClipPathFrame.h
>-  nsIFrame *mClipParent;
>+  nsIFrame *mClippedFrame;
>   nsAutoPtr<gfxMatrix> mClipParentMatrix;

I was going to comment that mClipParentMatrix's name is now a bit stale (since mClipParent has been renamed), but it looks like that matrix is going away in bug 1052915 anyway.

So, r=me
Attachment #8471965 - Flags: review?(dholbert) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/e8127cc0e8a0

I changed the name again to something more accurate, and will probably split this function shortly.
https://hg.mozilla.org/mozilla-central/rev/e8127cc0e8a0
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.