1052938 - [B2G][Flame][2.0][Contact] No error message prompted when exporting contacts to a full SD card.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Yeojin Chung [:YeojinC]]

Attachment: logcat_20140812_ExportingToFullSD.txt

Description:
The user is NOT prompted with a error message when exporting contacts to a full SD card on the Contacts app.

Repro Steps:
1. Insert a full SD card to the device.
2. Open the Contacts app.
3. Select the Settings icon.
4. Select "Export Contacts.
5. Select "Memory card".
6. Select all contacts.
7. Select "Export".

Actual:
The app stays on the "Export to SD Card" message indefinitely. 

Expected:
The user is prompted with a message notifying that the SD card is full.

Flame 2.0 (319mb)

Environmental Variables:
Device: Flame 2.0
Build ID: 20140812000205
Gaia: 1144cdc3a544f81c9bf71598aba1cb67d6c95a29
Gecko: 6495a7bd61ed
Version: 32.0 (2.0)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Repro Frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/14235/
See attached: logcat, video
http://youtu.be/hLmNFZWjJhA

Note: This but is the same issue observed in https://bugzilla.mozilla.org/show_bug.cgi?id=1026474 (FIXED on 2014-07-04 02:18:19 PDT )

Comment 1

[Yeojin Chung [:YeojinC]]

This issue also reproduces on Flame 2.0(512mb), Flame 2.1(319mb):

Flame 2.0 (512mb)

Environmental Variables:
Device: Flame 2.0
Build ID: 20140812000205
Gaia: 1144cdc3a544f81c9bf71598aba1cb67d6c95a29
Gecko: 6495a7bd61ed
Version: 32.0 (2.0)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Flame 2.1 (319mb)

Environmental Variables:
Device: Flame Master
Build ID: 20140812040201
Gaia: e78e62125eb43c3a28cdc047987ba54430694a2f
Gecko: b53c2753ce9a
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

The app stays on the "Export to SD Card" message indefinitely. 

========================================

This issue does NOT reproduce on Flame 1.4(319mb):

Flame 1.4 (319mb)

Environmental Variables:
Device: Flame 1.4
Build ID: 20140812063005
Gaia: ec395d47cee9234ae93d2410d8ef8724dfc5d6cb
Gecko: 5b219153e2f4
Version: 30.0 (1.4)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

The error message is prompted: "There's not enough space on the memory card to export the contacts".

Comment 2

[Yeojin Chung [:YeojinC]]

adding qawanted to check Buri & Open C.

Comment 3

[Yeojin Chung [:YeojinC]]

This issue also reproduces on Buri 2.1, Buri 2.0, Open C 2.0:

Buri 2.1

Environmental Variables:
Device: Buri Master
Build ID: 20140813073008
Gaia: 9f35fca9d818b26c06aa6b7e5c0bef25886f8f20
Gecko: 76b55c0850ca
Version: 34.0a1 (Master)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Buri 2.0

Environmental Variables:
Device: Buri 2.0
Build ID: 20140813063004
Gaia: e215fbf0cb16063b3d2f3e6a4e588c3550b6becb
Gecko: 8e88a30eef43
Version: 32.0 (2.0)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Open C 2.0

Environmental Variables:
Device: Open_C 2.0
BuildID: 20140813000201
Gaia: cade2fdbb2230670788dcf2fc7b100f4a37b6458
Gecko: a7c673dae1ed
Version: 32.0 (2.0) 
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

The app stays on the "Export to SD Card" message indefinitely. 

========================================

This issue does NOT reproduce on Buri 1.4, Open C 1.4:

Buri 1.4

Environmental Variables:
Device: Buri 1.4
Build ID: 20140813063003
Gaia: 5bb0edb3446df787c48dbb37272827ad94cb9245
Gecko: 3d30ba3dc503
Version: 30.0 (1.4)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Open C 1.4

Environmental Variables:
Device: Open_C 1.4
Build ID: 20140813063003
Gaia: 5bb0edb3446df787c48dbb37272827ad94cb9245
Gecko: 3d30ba3dc503
Version: 30.0 (1.4)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0


The error message is prompted: "There's not enough space on the memory card to export the contacts".

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

[Blocking Requested - why for this release]:

This is a regression from 1.4 and could lead to end user frustration since they might not realize their SD card is full. Nominating 2.0?

Comment 5

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

This is a really bad experience.

Comment 6

[Manuel Casas Barrado [:mancas]]

Attachment: Fixed error message

The problem was that "getStorageIfAvailable" function returns the available space so if the remaining space is zero, a logic condition with that value will be false.
That is the reason why the code related with the "no space available" it is not executed.

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8474489 [details] [review]
Fixed error message

Stealing review since Jose is on PTO

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Can we have unit tests for this PR?

I've checked against the phone, filling up my SDCARD and the patch seems to work, will be happier if we add more unit tests (we should have already for this case) to catch the error we have.

Comment 9

[Chris Kreinbring [:CKreinbring]]

Regression window unavailable.
The bug repros on the earliest Flame 2.0 and Buri 2.0 builds we have available.
Tested on 512 MB

Flame 2.0
BuildID: 20140417000006
Gaia: 7591e9dc782ac2e97d63a96f9deb71c7b3588328
Gecko: e71ed4135461
Platform Version: 31.0a1
Firmware Version: V123
User Agent: Mozilla/5.0 (Mobile; rv:31.0) Gecko/31.0 Firefox/31.0

Buri 2.0
BuildID: 20140318040206
Gaia: c03a6af9028c4b74a84b5a98085bbb0c07261175
Gecko: 5d61fabc49a8
Version: 31.0a1
Firmware: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:31.0) Gecko/31.0 Firefox/31.0

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Got unit test failing in gaia-try, just relaunched the job

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/5c32fc6ebf8468f0b5fa4f2f43269d0a06817928

Thanks for the work Manu

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/88db39a0826086024631049d83ae6aa397f0918d

Comment 13

[SandKing]

This issue has been verified successfully on Flame2.0&2.1
Verify video:"verify_1052938.mp4".

Flame2.0 build
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141130000204
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141130.032432
FW-Date         Sun Nov 30 03:24:44 EST 2014
Bootloader      L1TC00011880

Flame2.1 build:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141130001203
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141130.034738
FW-Date         Sun Nov 30 03:47:49 EST 2014
Bootloader      L1TC00011880

Comment 14

[SandKing]

Attachment: Verified video: verify_1052938.mp4