1053000 - scrollbar bar appears on call screen minimized mode when user launch app or send app to background

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[jinghua.xing]

Steps to reproduce
---------------------------------------------------------------
a) Power ON 7715 with operators in respective slot.
b) Make MTC on Sim 1 and receive the call.
c) Use data services.(as Facebook, Youtube etc..)
d) 7715 shows improper link blink on the green label while using data in call.

Steps to reproduce
---------------------------------------------------------------
7715 shows improper link blink on the green label while using data in call.

The branch of gaia which this issue happened on is v1.4, and the v1.3 branch has the same problem.

Comment 1

[jinghua.xing]

There is a more clear video on the path: ftp.spreadtrum.com/for_sprd_mozilla, it is named as Issue_2_Video.mp4. As this bug is caused by the pull request #21282, can you help me to check this bug please?

Timing of blink in the video provided
 00:05
 00:19
 00:25
 00:28
 00:41

Comment 2

[Etienne Segonzac (:etienne)]

Thanks for filing the bug!

(In reply to jinghua.xing from comment #1)
> There is a more clear video on the path:
> ftp.spreadtrum.com/for_sprd_mozilla, it is named as Issue_2_Video.mp4. As
> this bug is caused by the pull request #21282, can you help me to check this
> bug please?

I don't have the username/password to access this ftp :/

Comment 3

[jinghua.xing]

(In reply to Etienne Segonzac (:etienne) from comment #2)

> I don't have the username/password to access this ftp :/

I have send the username/password to you by email. Please check it. 

The video of bug 1053000 is ftp.spreadtrum.com/for_sprd_mozilla/Issue_2_Video.mp4
If you have not get the email or cannot get the video, please let me know and I will find other ways to provide it.

Thank you.

Comment 4

[Etienne Segonzac (:etienne)]

Attachment: 0001-Bug-1053000-WIP.patch

I can't reproduce the issue locally, but can you tell me if this patch helps?
Thanks!

Comment 5

[jinghua.xing]

(In reply to Etienne Segonzac (:etienne) from comment #4)
> Created attachment 8473014 [details] [diff] [review]
> 0001-Bug-1053000-WIP.patch
> 
> I can't reproduce the issue locally, but can you tell me if this patch helps?
> Thanks!

This patch works well on this issue. Thank you for your help. But I want to know how this issue happened?

As this issue happens on environment with only mozilla code, so can this patch landed and uplift it to v1.4 and v1.3t?
 
Thank you

Comment 6

[Etienne Segonzac (:etienne)]

(In reply to jinghua.xing from comment #5)
> (In reply to Etienne Segonzac (:etienne) from comment #4)
> > Created attachment 8473014 [details] [diff] [review]
> > 0001-Bug-1053000-WIP.patch
> > 
> > I can't reproduce the issue locally, but can you tell me if this patch helps?
> > Thanks!
> 
> This patch works well on this issue. Thank you for your help. But I want to
> know how this issue happened?
> 
> As this issue happens on environment with only mozilla code, so can this
> patch landed and uplift it to v1.4 and v1.3t?
>  
> Thank you

This patch's goal was only to confirm the issue. It's indeed not a fix but a work around.
"Something" is being displayed (and shouldn't) while the call screen is in minimized mode causing the scrollbars to appear.

We need to figure out what that "something" is now :)
Might be a RIL state we're not handling properly.
Do you know if the issue is reproducible on other hardware? (tarako or flame)
Trying to flash a dolphin in the mean time.

Comment 7

[jinghua.xing]

(In reply to Etienne Segonzac (:etienne) from comment #6)
> Do you know if the issue is reproducible on other hardware? (tarako or flame)
> Trying to flash a dolphin in the mean time.

Thank you for your help. I have test the case on tarako、flame and dolphin, and this issue have been reproduced on all these devices.

Comment 8

[Peipei Cheng (needinfo if you need my action)]

(In reply to Etienne Segonzac (:etienne) from comment #6)
> (In reply to jinghua.xing from comment #5)
> > (In reply to Etienne Segonzac (:etienne) from comment #4)
> > > Created attachment 8473014 [details] [diff] [review]
> > > 0001-Bug-1053000-WIP.patch
> > > 
> > > I can't reproduce the issue locally, but can you tell me if this patch helps?
> > > Thanks!
> > 
> > This patch works well on this issue. Thank you for your help. But I want to
> > know how this issue happened?
> > 
> > As this issue happens on environment with only mozilla code, so can this
> > patch landed and uplift it to v1.4 and v1.3t?
> >  
> > Thank you
> 
> This patch's goal was only to confirm the issue. It's indeed not a fix but a
> work around.
> "Something" is being displayed (and shouldn't) while the call screen is in
> minimized mode causing the scrollbars to appear.
> 
> We need to figure out what that "something" is now :)
> Might be a RIL state we're not handling properly.
> Do you know if the issue is reproducible on other hardware? (tarako or flame)
> Trying to flash a dolphin in the mean time.

This scrollbar could appear whenever user launch one app or send one app to background.

Comment 9

[Etienne Segonzac (:etienne)]

Attachment: Gair PR against 1.4

I think this is not happening on master thanks to bug 1007709.

Note that once this patch is reviewed we will need an approval for each branch to land.

Comment 10

[Anthony Ricaud (:rik)]

Comment on attachment 8477315 [details] [review]
Gair PR against 1.4

We can actually mark that node as |display: none| because we're not using it for dynamic font sizes in call bar mode. See https://github.com/mozilla-b2g/gaia/blob/f63cdae1a06c808443ed14de3cd13b61311426e0/apps/callscreen/js/handled_call.js#L244-L248

Also, we'll only need to uplift this to 2.0 since 2.1 is using another system for dynamic font sizes.

BTW, you should ask for blocking-b2g: 1.4? to give us permission to uplift this.

Comment 11

[jinghua.xing]

(In reply to Etienne Segonzac (:etienne) from comment #9)

> Note that once this patch is reviewed we will need an approval for each
> branch to land.

Hi etienne:

I want to know why this issue happened. 

Thank you.

Comment 12

[jinghua.xing]

I forgot to add a tag in comment 11

Comment 13

[Etienne Segonzac (:etienne)]

Comment on attachment 8477315 [details] [review]
Gair PR against 1.4

PR updated! (and re-tested on device)

Comment 14

[Etienne Segonzac (:etienne)]

Comment on attachment 8477315 [details] [review]
Gair PR against 1.4

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 990003
[User impact] if declined: scrollbars flashing in the minimized call screen
[Testing completed]: classic call and multi-calls scenarios
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: none

Comment 15

[bhavana bajaj [:bajaj]]

 jinghua,

I really need to see the video here to consider this for blocking. If you think this is something you would block the release on please state that along with the user impact and nominate it to 1.4?. Also, Ni'ing wayne here to see if this was highlighted to him or if he can help make a call here by watching the video.

Comment 16

[Wayne Chang [:wchang]]

We've looked at the video earlier and do not think this is release-blocking:
1: it only happens if user is on an active call and transmitting data in parallel
2: the actual user impact is low - cosmetic

Comment 17

[jinghua.xing]

This video is on  https://mega.co.nz/#!118jRDQb!dRPYNABBzMlfvTm5XU7gL4U8kj6rRPUFoBscfEZeF_I，please check it.

And the scrollbar bar appears on call screen minimized mode when user launch app or send app to background. So I think it need to be solved.

Comment 18

[Wayne Chang [:wchang]]

Jinghua,

Feel free to test the patch Etienne has provided and locally apply it if you're happy with it. 

Thanks.

Comment 19

[bhavana bajaj [:bajaj]]

(In reply to Wayne Chang [:wchang] from comment #18)
> Jinghua,
> 
> Feel free to test the patch Etienne has provided and locally apply it if
> you're happy with it. 
> 
> Thanks.

Jinghua, can you confirm this works?

Comment 20

[jinghua.xing]

I have tested this patch and it works well on this issue.

Thank you.

Comment 21

[bhavana bajaj [:bajaj]]

Comment on attachment 8477315 [details] [review]
Gair PR against 1.4

Clearing this per comment #18.

Comment 22

[Doug Sherk (:drs) (inactive)]

Per comment 9.