Replace openResultPopuup typo in autocomplete.xml by openPopup

RESOLVED FIXED in seamonkey2.32

Status

SeaMonkey
Autocomplete
--
trivial
RESOLVED FIXED
4 years ago
3 months ago

People

(Reporter: InvisibleSmiley, Assigned: Philip Chee)

Tracking

Trunk
seamonkey2.32

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
Bug 707039 renamed openResultPopup to openPopup in XPFE autocomplete.xml. Due to a typo, one instance in a comment was missed:

http://mxr.mozilla.org/comm-central/source/mozilla/xpfe/components/autocomplete/resources/content/autocomplete.xml#557
(Assignee)

Comment 2

4 years ago
Created attachment 8487023 [details] [diff] [review]
Patch v1.0 fix typo in comment

Simple replace
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Attachment #8487023 - Flags: review?(jh)
(Assignee)

Comment 3

4 years ago
Created attachment 8487027 [details] [diff] [review]
Patch v2.0 remove trailing white space in blank lines and comments only

This patch does two things:
Removes trailing whitespace in blank lines.
Removes trailing whitespace in comments only.
This shouldn't affect blame too much.
Attachment #8487027 - Flags: review?(jh)
(Reporter)

Updated

4 years ago
Attachment #8487023 - Flags: review?(jh) → review+
(Reporter)

Comment 4

4 years ago
Comment on attachment 8487027 [details] [diff] [review]
Patch v2.0 remove trailing white space in blank lines and comments only

Personally I don't mind having trailing whitespace removed; I even enforce it at my job and with private stuff. But my rules don't apply here strictly (unfortunately I'd say) so let's have Neil decide whether it's OK to do this here, not do it at all, or have its own bug.
Attachment #8487027 - Flags: review?(jh) → review?(neil)

Updated

4 years ago
Attachment #8487027 - Flags: review?(neil) → review+
https://hg.mozilla.org/mozilla-central/rev/d53c273e4777
https://hg.mozilla.org/mozilla-central/rev/8e2aa21fc19f
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.32

Comment 7

3 months ago
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/63e59ba6b2d5
Fix typo in autocomplete.xml comment, s/openResultPopuup/openPopup/ r=InvisibleSmiley DONTBUILD NPOTDB
https://hg.mozilla.org/comm-central/rev/3e9828cc49e7
Part 2 Remove trailing whitespace in blank lines and comments r=Neil DONTBUILD NPOTDB
You need to log in before you can comment on or make changes to this bug.