1053204 - FileDescriptor::CloseCurrentProcessHandle() close invalid file descriptor

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Sotaro Ikeda [:sotaro]]

+++ This bug was initially created as a clone of Bug #1038461 +++

This bug is created based on Bug 1038461 Comment 82.

When an application started from homescreen, b2g process close invalid fd.

Comment 1

[Sotaro Ikeda [:sotaro]]

[Blocking Requested - why for this release]:

Nominate to "b2g-2.0+", because this bug blocks Bug 1038461.

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: Call stack when invalid fd close happens

Get a call stack by uisng attachment 8472044 [details] [diff] [review], when an invalid fd is closed.

Comment 3

[Sotaro Ikeda [:sotaro]]

I confirmed that RemoteOpenFileParent::OpenSendCloseDelete() always close fd twice.

Comment 4

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #3)
> I confirmed that RemoteOpenFileParent::OpenSendCloseDelete() always close fd
> twice.

Therefore second fd close becomes "invalid fd close" or "different fd close(fd is already reused case)".

Comment 5

[Sotaro Ikeda [:sotaro]]

Bug 1047149 might be related to this bug.

Comment 6

[Sotaro Ikeda [:sotaro]]

Attachment: patch - remove redundant close()

Comment 7

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8472382 [details] [diff] [review]
patch - remove redundant close()

bent, can you review the patch soon? This bug blocks b2g-v2.0+ bug.

Comment 8

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8472382 [details] [diff] [review]
patch - remove redundant close()

Review of attachment 8472382 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

Comment 9

[Dietrich Ayala (:dietrich)]

Blocks a crash blocker -> blocking+.

Comment 10

[Sotaro Ikeda [:sotaro]]

hg repository and tryserver is closed now.

Comment 11

[Gregor Wagner [:gwagner]]

Tapas, can you include this in your test run?

Comment 12

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #10)
> hg repository and tryserver is closed now.

It seems to be tracked by Bug 1040308.

Comment 13

[Inder]

Gregor -- yes we are going to include this in the next run.

Comment 14

[Sotaro Ikeda [:sotaro]]

https://tbpl.mozilla.org/?tree=Try&rev=84949f4264e5

Comment 15

[Sotaro Ikeda [:sotaro]]

 https://hg.mozilla.org/integration/mozilla-inbound/rev/8f922378fab0

Comment 16

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8f922378fab0

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/0c5081fcfd22

Comment 18

[Nicholas Troast [:ntroast]]

attachment 8472382 [details] [diff] [review] landed in AU63