1053357 - Search terms with multiple spaces are displayed with plus signs in the location bar

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[:Paolo Amadini]

Attachment: The patch

This is an implementation bug in the patch for bug 1040721, for which search terms with multiple spaces are displayed with plus signs.

Comment 1

[:Paolo Amadini]

https://hg.mozilla.org/integration/fx-team/rev/109eda4ae723

Comment 2

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/109eda4ae723

Comment 3

[Andrei Vaida [:avaida]]

Reproduced the initial issue on the August 13th Nightly.

This is now verified fixed on Nightly 34 (2014-08-17) using Windows 7 64-bit, Ubuntu 14.04 LTS 32-bit and Mac OS X 10.9.4, with various search keywords containing multiple spaces. 

Upon testing this fix though, I noticed a few potential issues:
1) on a new profile, clicking the arrow button from the Location Bar has no effect if the user hasn't accessed yet any URLs directly (i.e. the user only performed searches, by typing keywords and hitting the <enter> key, w/o accessing any URLs such as http://example.com/ directly)
2) typing a keyword and then adding several spaces after it, makes the results pane scrollbar flicker (this is reproducible across platforms - might be related to Bug 1047613? -, but I noticed it's more visible on Windows)

Paolo, please let me know what you think about these. 

I suspect none of them are related to this fix, so if needed, I'll file follow-up bugs and track them separately, closing this one.

Comment 4

[:Paolo Amadini]

(In reply to Andrei Vaida, QA [:avaida] from comment #3)
> 1) on a new profile, clicking the arrow button from the Location Bar has no
> effect if the user hasn't accessed yet any URLs directly (i.e. the user only
> performed searches, by typing keywords and hitting the <enter> key, w/o
> accessing any URLs such as http://example.com/ directly)

Sounds like a bug!

> 2) typing a keyword and then adding several spaces after it, makes the
> results pane scrollbar flicker (this is reproducible across platforms -
> might be related to Bug 1047613? -, but I noticed it's more visible on
> Windows)

Definitely bug 1047613.

Comment 5

[Andrei Vaida [:avaida]]

Many thanks for the prompt reply! :) 
I'll file a new bug for issue 1) as soon as I finish my tests.