Search terms with multiple spaces are displayed with plus signs in the location bar

VERIFIED FIXED in Firefox 34

Status

()

defect
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: Paolo, Assigned: Paolo)

Tracking

Trunk
Firefox 34
Points:
1
Dependency tree / graph
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(firefox34 verified)

Details

Attachments

(1 attachment)

Assignee

Description

5 years ago
Posted patch The patchSplinter Review
This is an implementation bug in the patch for bug 1040721, for which search terms with multiple spaces are displayed with plus signs.
Attachment #8472498 - Flags: review?(gavin.sharp)
Attachment #8472498 - Flags: review?(gavin.sharp) → review+
Iteration: --- → 34.2
Points: --- → 1
Flags: firefox-backlog+
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
QA Whiteboard: [qa?]
QA Whiteboard: [qa?] → [qa+]
QA Contact: alexandra.lucinet
https://hg.mozilla.org/mozilla-central/rev/109eda4ae723
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
QA Contact: alexandra.lucinet → andrei.vaida
Reproduced the initial issue on the August 13th Nightly.

This is now verified fixed on Nightly 34 (2014-08-17) using Windows 7 64-bit, Ubuntu 14.04 LTS 32-bit and Mac OS X 10.9.4, with various search keywords containing multiple spaces. 

Upon testing this fix though, I noticed a few potential issues:
1) on a new profile, clicking the arrow button from the Location Bar has no effect if the user hasn't accessed yet any URLs directly (i.e. the user only performed searches, by typing keywords and hitting the <enter> key, w/o accessing any URLs such as http://example.com/ directly)
2) typing a keyword and then adding several spaces after it, makes the results pane scrollbar flicker (this is reproducible across platforms - might be related to Bug 1047613? -, but I noticed it's more visible on Windows)

Paolo, please let me know what you think about these. 

I suspect none of them are related to this fix, so if needed, I'll file follow-up bugs and track them separately, closing this one.
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa+] → [qa!]
Flags: needinfo?(paolo.mozmail)
Assignee

Comment 4

5 years ago
(In reply to Andrei Vaida, QA [:avaida] from comment #3)
> 1) on a new profile, clicking the arrow button from the Location Bar has no
> effect if the user hasn't accessed yet any URLs directly (i.e. the user only
> performed searches, by typing keywords and hitting the <enter> key, w/o
> accessing any URLs such as http://example.com/ directly)

Sounds like a bug!

> 2) typing a keyword and then adding several spaces after it, makes the
> results pane scrollbar flicker (this is reproducible across platforms -
> might be related to Bug 1047613? -, but I noticed it's more visible on
> Windows)

Definitely bug 1047613.
Flags: needinfo?(paolo.mozmail)
Many thanks for the prompt reply! :) 
I'll file a new bug for issue 1) as soon as I finish my tests.
You need to log in before you can comment on or make changes to this bug.