1053423 - Polish context menus

Status: RESOLVED FIXED

(Webtools Graveyard :: DXR, defect)

Description

[Erik Rose [:erik][:erikrose]]

Go to http://dxr.mozilla.org/mozilla-central/source/accessible/atk/AccessibleWrap.cpp, and, on line 36, click AccessibleWrap. There's lot wrong with such context menus:

* Let's get a few pixels of padding inside the edges of the menu.
* "Find definitions" and "Find references" have the same icon.
* Many things don't have icons at all. Maybe we should have more. Maybe we should have none. But let's be consistent or *at least* have all the menu item text start at the same horizontal position.
* The noise word "Find" is repeated over and over again.

Comment 1

[[github robot]]

Commit pushed to master at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/567ccb97d6aae937ee6dccc26f9186fa2ace0d7b
Fixing bugs: 1053423, 1052524 and 965652
For 965652:
	dxr.css :
	Added a rule for .code code a in order to show availability of context-menus but limited in order not to overwrite a rule somewhere else.
For 1052524:
	file.html :
	Added the .icon class to all anchors in the panel
	dxr.css :
	Removed padding form (.panel section a) since it blocks the added .icon class
For 1053423:
	context_menu.html :
	Added the .icon class to all anchors in the list in order to have a pseudoparent class and eliminate a lot of repeating in icons.css
	dxr.css :
	Removed padding from (.context-menu a) since it blocks the added .icon class
	icons.css :
	Made a lot of changes and removed the repeating rules for background since they are no longer needed because of the .icon class
Other:
Fixed .build in icons.css that I missed it the last time.
Added comments in icons.css in order to show rearanged sections.
Added a lot missing icon classes which are referenced in .panel and .context-menu .
Since the .panel icons that are always shown are probably going to be redone they are commented out untill the time has come.
That's about it. Will mention if I find something else.

Comment 2

[[github robot]]

Commit pushed to es at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/567ccb97d6aae937ee6dccc26f9186fa2ace0d7b
Fixing bugs: 1053423, 1052524 and 965652