1053599 - Move org.mozilla.gecko.sync.setup.activities.WebURLFinder out of Sync's setup package

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Android Sync, defect, P5)

Description

[Chris Kitching [:ckitching]]

This class has more general application: let's move it out of sync so our imports make more sense (and so it's slightly less well hidden).

Comment 1

[akshaytiwari.003]

I'd like to work on this, can you tell me where is this located in the repository. I'm new to this community. 

Thank you.

Comment 2

[Chris Kitching [:ckitching]]

(In reply to akshaytiwari.003 from comment #1)
> I'd like to work on this, can you tell me where is this located in the
> repository. I'm new to this community. 
> 
> Thank you.

Hi!

Sorry for taking so long to get back to you: it's been a hectic week! (also the guy who's ostensibly mentoring this bug is on holiday, so I'll have a stab at taking over).

So your first steps should be to get the repo cloned and your first build working okay. You can find some quite good instructions on how to do that here:
https://wiki.mozilla.org/Mobile/Fennec/Android

If things go pear-shaped, head onto Mozilla IRC and ask in #introduction for help. If you wish to get in touch about something other than "halp, I can't get my build going first time" come ask us in #mobile: my handle there is ckitching. It tends to be a good way to rapidly get straightforward questions answered.

The Java code for Firefox for Android (that is, the code we care about for this bug) is found at mobile/android/base inside the repo.
From there, you'll find the org.mozilla.gecko.sync.setup.activities.WebURLFinder class at sync/setup/activities/WebURLFinder.java

The class is hidden away inside sync, which is annoying: it's more generally useful. Let's move it into org.mozilla.gecko.util (or maybe you have a suggestion for somewhere that'd make even more sense?)
Just a simple refactoring patch: but once you get the hang of it I'll be happy to point you to some more technically interesting bugs to work on!

One final complication: Android sync lives in its own separate repository on GitHub. As a result, as well as generating a patch for mozilla-central in the usual way, once you get approval you'll need to follow the instructions on GitHub for getting the appropriate changes committed upstream:
https://github.com/mozilla-services/android-sync

Good luck!

Comment 3

[Richard Newman [:rnewman]]

The work should be done in the Git repo; it'll involve touching code, manifests, and tests that aren't washed downstream into Fennec.

Comment 4

[:Grisha Kruglov]

This code is now part of mozilla-central. Otherwise, Comment 2 still applies. Tests should be converted to regular junit4 tests.

Comment 5

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 6

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.