Closed
Bug 1053621
Opened 11 years ago
Closed 11 years ago
Remove uses of PR_NOT_REACHED from the mozilla::pkix test suite
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: briansmith, Assigned: briansmith)
Details
Attachments
(1 file)
|
1.83 KB,
patch
|
keeler
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8472778 -
Flags: review?(dkeeler)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8472778 [details] [diff] [review]
no-more-PR_NOT_REACHED.patch
Review of attachment 8472778 [details] [diff] [review]:
-----------------------------------------------------------------
::: security/pkix/test/lib/pkixtestutil.cpp
@@ +1412,5 @@
> der::CONTEXT_SPECIFIC | der::CONSTRUCTED | 1,
> revocationTime);
> }
> default:
> + assert(false);
Any particular reason we don't want to continue to abort() here?
Attachment #8472778 -
Flags: review?(dkeeler) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8472778 [details] [diff] [review]
no-more-PR_NOT_REACHED.patch
Review of attachment 8472778 [details] [diff] [review]:
-----------------------------------------------------------------
::: security/pkix/test/lib/pkixtestutil.cpp
@@ +1412,5 @@
> der::CONTEXT_SPECIFIC | der::CONSTRUCTED | 1,
> revocationTime);
> }
> default:
> + assert(false);
In general, we (should) only call abort when we don't have another way of indicating an error has occurred. Here, returning nullptr is the way to indicate an error has occurred.
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•