1053674 - Remove subclass of StateMachine and use task queue directly

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Matthew Gregan [:kinetik]]

Rather than have an ugly subclass of MediaDecoderStateMachine just to get a
reference to the reader and task queue, give MediaSourceReader its own task
queue (from the same pool as the queue we were using).

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: Remove subclass of StateMachine and use our own task queue.

Comment 2

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/012b4107cfa0

Comment 3

[Matthew Gregan [:kinetik]]

Attachment: Shut down MSR task queue.

Comment 4

[Nigel Babu [:nigelb]]

Backed out for mochitest-1 and crashtest bustage

https://hg.mozilla.org/integration/mozilla-inbound/rev/a7d98b35305f

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8473524 [details] [diff] [review]
Shut down MSR task queue.

Review of attachment 8473524 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/mediasource/MediaSourceReader.cpp
@@ +46,5 @@
>  }
>  
> +MediaSourceReader::~MediaSourceReader()
> +{
> +  mTaskQueue->Shutdown();

Do this at the end of your MediaDecoderReader::Shutdown() override.

Funny, I had wondered if this would be a problem with your previous patch, but I figured since your Shutdown() override already called Shutdown() on the subreaders, it would be ok. Guess not.. :P

Comment 6

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0f59a9eb1658

Comment 7

[Matthew Gregan [:kinetik]]

And backed out again:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9bde32496fa3

Due to bustage:
https://tbpl.mozilla.org/php/getParsedLog.php?id=46144803&tree=Mozilla-Inbound#error0

Comment 8

[Matthew Gregan [:kinetik]]

Attachment: Remove subclass of StateMachine and use task queue directly. v2

Comment 9

[Matthew Gregan [:kinetik]]

Simpler approach: use the existing task queue directly, rather than going via MDSM.

Comment 10

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/65c3554ccc07

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/65c3554ccc07