Remove subclass of StateMachine and use task queue directly

RESOLVED FIXED in mozilla34

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kinetik, Assigned: kinetik)

Tracking

(Blocks: 1 bug)

unspecified
mozilla34
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Rather than have an ugly subclass of MediaDecoderStateMachine just to get a
reference to the reader and task queue, give MediaSourceReader its own task
queue (from the same pool as the queue we were using).
(Assignee)

Comment 1

5 years ago
Created attachment 8472844 [details] [diff] [review]
Remove subclass of StateMachine and use our own task queue.
Attachment #8472844 - Flags: review?(cpearce)
(Assignee)

Updated

5 years ago
Depends on: 778617
Attachment #8472844 - Flags: review?(cpearce) → review+
(Assignee)

Comment 3

5 years ago
Created attachment 8473524 [details] [diff] [review]
Shut down MSR task queue.
Attachment #8473524 - Flags: review?(cpearce)
Backed out for mochitest-1 and crashtest bustage

https://hg.mozilla.org/integration/mozilla-inbound/rev/a7d98b35305f
Comment on attachment 8473524 [details] [diff] [review]
Shut down MSR task queue.

Review of attachment 8473524 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/mediasource/MediaSourceReader.cpp
@@ +46,5 @@
>  }
>  
> +MediaSourceReader::~MediaSourceReader()
> +{
> +  mTaskQueue->Shutdown();

Do this at the end of your MediaDecoderReader::Shutdown() override.

Funny, I had wondered if this would be a problem with your previous patch, but I figured since your Shutdown() override already called Shutdown() on the subreaders, it would be ok. Guess not.. :P
Attachment #8473524 - Flags: review?(cpearce) → review+
(Assignee)

Updated

5 years ago
Attachment #8473524 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #8472844 - Attachment is obsolete: true
(Assignee)

Comment 8

5 years ago
Created attachment 8474373 [details] [diff] [review]
Remove subclass of StateMachine and use task queue directly. v2
Attachment #8474373 - Flags: review?(cpearce)
(Assignee)

Updated

5 years ago
Summary: Remove subclass of StateMachine and use our own task queue. → Remove subclass of StateMachine and use task queue directly
(Assignee)

Comment 9

5 years ago
Simpler approach: use the existing task queue directly, rather than going via MDSM.
Attachment #8474373 - Flags: review?(cpearce) → review+
https://hg.mozilla.org/mozilla-central/rev/65c3554ccc07
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
(Assignee)

Updated

5 years ago
Blocks: 778617
No longer depends on: 778617
You need to log in before you can comment on or make changes to this bug.