1053684 - [Clock] The Alarm sound volume is set at maximum after some common operations

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Julien Wajsberg [:julienw]]

STR:
1. Set a new alarm in the clock application
2. kill the clock application
3. Open Settings > Sound and decrease the "Alarm" volume
4. open the clock application, edit the previously set alarm, change the time, save
5. open settings again, check that the "alarm" volume has been set to the maximum

The issue is that, at 4th step, the "system alarm volume" cursor is set at the max, while it should be set at the current system volume level.

Note 1: it's correctly set if you try to edit an alarm a second time; only the first time after launching the app shows the issue
Note 2: happens also when setting a new alarm, although the issue is much more annoying when editing an existing alarm, that's why I choose this STR.


[Blocking Requested - why for this release]: regression. And I wouldn't ship a phone with this bug, this is very VERY annoying.

Comment 1

[Jason Smith [:jsmith]]

QA Wanted for branch checks.

Comment 2

[Pi Wei Cheng [:piwei] (inactive)]

This issue is reproducible on Flame 2.1, Flame 2.0, and Buri 2.0.

Observed behavior: After following STR, alarm volume gets reset to maximum despite at step 3 the volume had been decreased.

Device: Flame 2.1 Master
BuildID: 20140814005107
Gaia: 5e074831f9ddacdf6f622a6dffaecb626f740be8
Gecko: 5299864050ee
Version: 34.0a1 (2.1 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Device: Flame 2.0
BuildID: 20140814024604
Gaia: d889984833025f208cfd3f3c2c37c87940a529dc
Gecko: abdb13f41d68
Version: 32.0 (2.0)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Device: Buri 2.0
BuildID: 20140814062905
Gaia: d889984833025f208cfd3f3c2c37c87940a529dc
Gecko: 0c5081fcfd22
Version: 32.0 (2.0)
Firmware: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

-----------

This issue does NOT occur on Flame 1.4.

Observed behavior: Following STR, the alarm volume remains the same as what was set at step 3.

Device: Flame 1.4
BuildID: 20140814070608
Gaia: b3c3ca346985d43ff239281a69b52a69ee6ba6cb
Gecko: 9d7b18537fdb
Version: 30.0 (1.4)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Comment 3

[Joshua Mitchell (Inactive)]

+1 for 2.0 nom, losing user preference data = very bad.

Comment 4

[Pi Wei Cheng [:piwei] (inactive)]

This issue occurs on the earliest Flame central build that we have available (4/17), therefore we can only find the window using Buri with nightly builds.

Hamachi Nightly regression window:

Last Working Environmental Variables:
Device: Buri
BuildID: 20140402160201
Gaia: 04d96dd43e2c5c673a0c73b5a65faeb115c2065f
Gecko: 7bacc9e903b0
Version: 31.0a1
Firmware v1.2device.cfg

First Broken Environmental Variables:
Device: Buri
BuildID: 20140403040201
Gaia: 0e974ff33ba47f3d1e59df1e0ad534f1bbe3ef8a
Gecko: 91be2828f17e
Version: 31.0a1
Firmware v1.2device.cfg

First broken gecko & last working gaia - issue does NOT repro
Gaia: 04d96dd43e2c5c673a0c73b5a65faeb115c2065f
Gecko: 91be2828f17e

First broken gaia & last working gecko - issue DOES repro
Gaia: 0e974ff33ba47f3d1e59df1e0ad534f1bbe3ef8a
Gecko: 7bacc9e903b0

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/04d96dd43e2c5c673a0c73b5a65faeb115c2065f...0e974ff33ba47f3d1e59df1e0ad534f1bbe3ef8a

Caused by Bug 939197 ?

Comment 5

[Joshua Mitchell (Inactive)]

broken by Bug 939197 ? Marcus - could you take a look?

Comment 6

[Manuel Casas Barrado [:mancas]]

Attachment: Fixed alarm volume

The main problem was an asynchronous call.

Input field request the current system alarm volume but the API is asynchronous so we need to make a promise to avoid this wrong behaviour and prevent "input" from retrieving the default volume

Comment 7

[Julien Wajsberg [:julienw]]

Comment on attachment 8474404 [details] [review]
Fixed alarm volume

Moving the review request to Marcus, I don't think Mike is still working with us.

Comment 8

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8474404 [details] [review]
Fixed alarm volume

Thanks, that looks perfect. r=mcav, landed for you since this is a blocker.

master: https://github.com/mozilla-b2g/gaia/commit/9b705d2b7f9ed44804ba57d8e3e9e999e72d7dbf

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/c6836ffacdd851a9d8b2df1793fc2ed92ff861e4

Comment 10

[Edward Chen[:edchen]]

[Environment]
Gaia      e424c85eda87a40c0fa64d6a779c3fa368bf770b
Gecko     https://hg.mozilla.org/mozilla-central/rev/daa84204a11a
BuildID   20140824160205
Version   34.0a1
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014

[Result]
PASS

Comment 11

[Paladin]

Attachment: Verify_image.3gp

This issue has been verified successfully on Flame 2.1

See attachment: Verify_image.3gp
Reproducing rate: 0/5
Flame 2.1 build:
Gaia-Rev        db2e84860f5a7cc334464618c6ea9e92ff82e9dd
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/211eae88f119
Build-ID        20141126001202
Version         34.0