Open Bug 1053727 Opened 7 years ago Updated 4 years ago

GMPParent & GMPChild should receive plugin paths instead of constructing them themselves

Categories

(Core :: WebRTC: Audio/Video, defect, P5)

defect

Tracking

()

Blocking Flags:

People

(Reporter: gfritzsche, Unassigned)

References

Details

Both GMPParent & GMPChild depend on our path convention for GMP to extract the gmp plugin id to construct name/binaryName:
https://hg.mozilla.org/mozilla-central/annotate/6a7be7376caa/content/media/gmp/GMPParent.cpp#l100
https://hg.mozilla.org/mozilla-central/annotate/6a7be7376caa/content/media/gmp/GMPChild.cpp#l66

We already have this logic in GMPInstallManager & OpenH264Provider, i don't see why we need to have it in yet another place.
We could just pass the gmp plugin id through instead.
Flags: firefox-backlog+
The path convention is what lets them find the .info file and the DLL without scanning the directory. To change this you'd also have to change the MOZ_GMP_PATH logic. Is this really worth changing?
Flags: needinfo?(georg.fritzsche)
I don't think it's important, but it would be good to not have dependencies on the path structure spread across the tree.
It just extracts the plugin id, which is already known in other places when registering, so why not pass it in instead?
Flags: needinfo?(georg.fritzsche)
Depends on: 1040905
backlog: --- → webRTC+
Rank: 55
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.