1053729 - Remove old GMP installs

Status: RESOLVED INACTIVE

(Toolkit :: Add-ons Manager, defect)

Description

[Georg Fritzsche [:gfritzsche]]

We should check for old GMP installs and remove them.
Given the path convention of <profile-dir>/<gmp-plugin-id>/<version>, we can just check if <profile-dir>/<gmp-plugin-id>/ contains any other subdirs than <current-version> and remove them.

Possible location: OpenH264Provider startup.

Comment 1

[Benjamin Smedberg]

We have to be careful here: in the future during Firefox update we may download a new version of OpenH264, and so we may have at least one new version.

I would think that this should be part of GMPInstallManager, not the addon provider.

Comment 2

[Qeole]

Remark: once it's implemented, there would probably be some tests to add and/or update in toolkit/mozapps/extensions/test/xpcshell/test_openH264.js
(In particular, I'm thinking about this one -> [1], once patch from bug 1045209 − see bug 1045209 comment #31 − has been checked-in).

[1] https://hg.mozilla.org/mozilla-central/annotate/0aaa2d3d15cc/toolkit/mozapps/extensions/test/xpcshell/test_openh264.js#l218

Comment 5

[Chris Peterson [:cpeterson]]

Stephen: does your CDM uninstall fix cover all GMP plugins?

Comment 6

[Stephen A Pohl [:spohl]]

The uninstall work that has occurred so far applies to all GMPs that are *currently registered* when an update occurs. It seems like this bug is asking for a more general cleanup, including old GMPs that may have been left on disk for one reason or another (in-use during update etc.).

Comment 7

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.