Add a Learn more link to the support page in feeds subscribe dialog

RESOLVED FIXED in Thunderbird 36.0

Status

defect
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: alta88, Assigned: alta88)

Tracking

unspecified
Thunderbird 36.0

Thunderbird Tracking Flags

(thunderbird36 fixed)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

5 years ago
As it is there is almost no support noise regarding feeds; making a guide available should reduce even that.
(Assignee)

Comment 1

5 years ago
Posted patch learnmore.patch (obsolete) — Splinter Review
Assignee: nobody → alta88
Attachment #8472976 - Flags: review?(mkmelin+mozilla)
(Assignee)

Comment 2

5 years ago
Posted patch suitestr.patch (obsolete) — Splinter Review
Attachment #8472978 - Flags: review?(philip.chee)
(Assignee)

Comment 3

5 years ago
actually, the string "Learn more about using Feeds" should be "Learn more about Feeds".  feedback?

Comment 4

5 years ago
Comment on attachment 8472978 [details] [diff] [review]
suitestr.patch

I'm on holiday until 1st September, plus am having to deal with a large backlog of bugmail. Redirecting review request -> IanN
Attachment #8472978 - Flags: review?(philip.chee) → review?(iann_bugzilla)
Comment on attachment 8472976 [details] [diff] [review]
learnmore.patch

Review of attachment 8472976 [details] [diff] [review]:
-----------------------------------------------------------------

With this patch the "account tree" in the subscribe dialog is only ~ one line. (It's only about 2-3 lines before the patch too.)

Also, would it be better in the bottom right corner instead of being the first thing in the dialog.

::: mail/locales/en-US/chrome/messenger-newsblog/feed-subscriptions.dtd
@@ +3,5 @@
>     - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
>  
>  <!-- Subscription Dialog -->
>  <!ENTITY feedSubscriptions.label     "Feed Subscriptions">
> +<!ENTITY learnMore.label             "Learn more about using Feeds">

Yeah "Learn more about Feeds" would be my prefernce too
Attachment #8472976 - Flags: review?(mkmelin+mozilla) → review-
(Assignee)

Comment 6

5 years ago
(In reply to Magnus Melin from comment #5)
> Comment on attachment 8472976 [details] [diff] [review]
> learnmore.patch
> 
> Review of attachment 8472976 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> With this patch the "account tree" in the subscribe dialog is only ~ one
> line. (It's only about 2-3 lines before the patch too.)

the dialog is resizable/persistable, and the tree flexes to fit the dialog.  not clear what you mean, perhaps a screenshot.  perhaps the localstore.rdf change had a temporary effect.

> 
> Also, would it be better in the bottom right corner instead of being the
> first thing in the dialog.
> 

i really think it's important the Learn More is top right and not minimized away, and more important that the 'Note: Removing..' string is de-emphasized by being placed at the bottom; it should never have been at the top.  so both at the bottom would be cluttered.  at some point if a Search textbox is added, it would be top left and thus things would fit.

should we get a UI feedback, ie blake or paenglab or josiah?

> ::: mail/locales/en-US/chrome/messenger-newsblog/feed-subscriptions.dtd
> @@ +3,5 @@
> >     - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
> >  
> >  <!-- Subscription Dialog -->
> >  <!ENTITY feedSubscriptions.label     "Feed Subscriptions">
> > +<!ENTITY learnMore.label             "Learn more about using Feeds">
> 
> Yeah "Learn more about Feeds" would be my prefernce too

yes.
(Assignee)

Comment 7

5 years ago
Comment on attachment 8472976 [details] [diff] [review]
learnmore.patch


blake, please advise about the "Learn more" and "Note: Removing" placement, whether as per patch or some other.
Attachment #8472976 - Flags: ui-review?(bwinton)
Comment on attachment 8472976 [details] [diff] [review]
learnmore.patch

Review of attachment 8472976 [details] [diff] [review]:
-----------------------------------------------------------------

Tried it with another profile and that looks fine, so it must have been something with that profile...
Attachment #8472976 - Flags: review- → review+
Comment on attachment 8472976 [details] [diff] [review]
learnmore.patch

Yeah, "Learn more about Feeds".
The positions seem…  well, not perfect, but I can't think of a better place to put them, so let's go with this.  ;)

(I think we could probably remove the "Note:", and put that info in the "Learn more" page, but if you wanted to do that in a followup bug, that would be fine by me.)

Thanks,
Blake.
Attachment #8472976 - Flags: ui-review?(bwinton) → ui-review+
(Assignee)

Comment 10

5 years ago
for checkin, updated for comments (removed Note: too).
Attachment #8472976 - Attachment is obsolete: true
Attachment #8489544 - Flags: ui-review+
Attachment #8489544 - Flags: review+
(Assignee)

Comment 11

5 years ago
suite strings.
Attachment #8472978 - Attachment is obsolete: true
Attachment #8472978 - Flags: review?(iann_bugzilla)
Attachment #8489545 - Flags: review?(iann_bugzilla)

Updated

5 years ago
Attachment #8489545 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/4290d9ad4d15
https://hg.mozilla.org/comm-central/rev/e074346e8a12
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 36.0
You need to log in before you can comment on or make changes to this bug.