1053782 - Add a Learn more link to the support page in feeds subscribe dialog

Status: RESOLVED FIXED

(MailNews Core :: Feed Reader, defect)

Description

[alta88]

As it is there is almost no support noise regarding feeds; making a guide available should reduce even that.

Comment 1

[alta88]

Attachment: learnmore.patch

Comment 2

[alta88]

Attachment: suitestr.patch

Comment 3

[alta88]

actually, the string "Learn more about using Feeds" should be "Learn more about Feeds".  feedback?

Comment 4

[Philip Chee]

Comment on attachment 8472978 [details] [diff] [review]
suitestr.patch

I'm on holiday until 1st September, plus am having to deal with a large backlog of bugmail. Redirecting review request -> IanN

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 8472976 [details] [diff] [review]
learnmore.patch

Review of attachment 8472976 [details] [diff] [review]:
-----------------------------------------------------------------

With this patch the "account tree" in the subscribe dialog is only ~ one line. (It's only about 2-3 lines before the patch too.)

Also, would it be better in the bottom right corner instead of being the first thing in the dialog.

::: mail/locales/en-US/chrome/messenger-newsblog/feed-subscriptions.dtd
@@ +3,5 @@
>     - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
>  
>  <!-- Subscription Dialog -->
>  <!ENTITY feedSubscriptions.label     "Feed Subscriptions">
> +<!ENTITY learnMore.label             "Learn more about using Feeds">

Yeah "Learn more about Feeds" would be my prefernce too

Comment 6

[alta88]

(In reply to Magnus Melin from comment #5)
> Comment on attachment 8472976 [details] [diff] [review]
> learnmore.patch
> 
> Review of attachment 8472976 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> With this patch the "account tree" in the subscribe dialog is only ~ one
> line. (It's only about 2-3 lines before the patch too.)

the dialog is resizable/persistable, and the tree flexes to fit the dialog.  not clear what you mean, perhaps a screenshot.  perhaps the localstore.rdf change had a temporary effect.

> 
> Also, would it be better in the bottom right corner instead of being the
> first thing in the dialog.
> 

i really think it's important the Learn More is top right and not minimized away, and more important that the 'Note: Removing..' string is de-emphasized by being placed at the bottom; it should never have been at the top.  so both at the bottom would be cluttered.  at some point if a Search textbox is added, it would be top left and thus things would fit.

should we get a UI feedback, ie blake or paenglab or josiah?

> ::: mail/locales/en-US/chrome/messenger-newsblog/feed-subscriptions.dtd
> @@ +3,5 @@
> >     - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
> >  
> >  <!-- Subscription Dialog -->
> >  <!ENTITY feedSubscriptions.label     "Feed Subscriptions">
> > +<!ENTITY learnMore.label             "Learn more about using Feeds">
> 
> Yeah "Learn more about Feeds" would be my prefernce too

yes.

Comment 7

[alta88]

Comment on attachment 8472976 [details] [diff] [review]
learnmore.patch


blake, please advise about the "Learn more" and "Note: Removing" placement, whether as per patch or some other.

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 8472976 [details] [diff] [review]
learnmore.patch

Review of attachment 8472976 [details] [diff] [review]:
-----------------------------------------------------------------

Tried it with another profile and that looks fine, so it must have been something with that profile...

Comment 9

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 8472976 [details] [diff] [review]
learnmore.patch

Yeah, "Learn more about Feeds".
The positions seem…  well, not perfect, but I can't think of a better place to put them, so let's go with this.  ;)

(I think we could probably remove the "Note:", and put that info in the "Learn more" page, but if you wanted to do that in a followup bug, that would be fine by me.)

Thanks,
Blake.

Comment 10

[alta88]

Attachment: learnmore.patch

for checkin, updated for comments (removed Note: too).

Comment 11

[alta88]

Attachment: suitestr.patch

suite strings.

Comment 12

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/4290d9ad4d15
https://hg.mozilla.org/comm-central/rev/e074346e8a12