1053792 - Fix some bad implicit constructors in the mtransport code

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Comment 1

[(no longer active)]

Attachment: Fix some bad implicit constructors in the mtransport code

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8472989 [details] [diff] [review]
Fix some bad implicit constructors in the mtransport code

Review of attachment 8472989 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the generation script modified for runnable_utils, and used to generate the new runnable_utils_generated.h

::: media/mtransport/runnable_utils_generated.h
@@ +5,5 @@
>  
>  // 0 arguments --
>  template<typename M> class runnable_args_nm_0 : public detail::runnable_args_base<detail::NoResult> {
>   public:
> +  explicit runnable_args_nm_0(M m) :

Also modify the generator script

::: media/mtransport/sigslot.h
@@ +306,5 @@
>  	{
>  	public:
>  		mt_policy *m_mutex;
>  
> +		explicit lock_block(mt_policy *mtx)

I'll note this is imported code, but that's ok

Comment 3

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/39c9d9bba87e

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/39c9d9bba87e