Closed Bug 1053792 Opened 5 years ago Closed 5 years ago

Fix some bad implicit constructors in the mtransport code

Categories

(Core :: WebRTC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → ehsan
Blocks: explicit
Attachment #8472989 - Flags: review?(rjesup)
Comment on attachment 8472989 [details] [diff] [review]
Fix some bad implicit constructors in the mtransport code

Review of attachment 8472989 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the generation script modified for runnable_utils, and used to generate the new runnable_utils_generated.h

::: media/mtransport/runnable_utils_generated.h
@@ +5,5 @@
>  
>  // 0 arguments --
>  template<typename M> class runnable_args_nm_0 : public detail::runnable_args_base<detail::NoResult> {
>   public:
> +  explicit runnable_args_nm_0(M m) :

Also modify the generator script

::: media/mtransport/sigslot.h
@@ +306,5 @@
>  	{
>  	public:
>  		mt_policy *m_mutex;
>  
> +		explicit lock_block(mt_policy *mtx)

I'll note this is imported code, but that's ok
Attachment #8472989 - Flags: review?(rjesup) → review+
https://hg.mozilla.org/mozilla-central/rev/39c9d9bba87e
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.