Closed Bug 1053797 Opened 7 years ago Closed 7 years ago

enable os x l10n builds on oak

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Unassigned)

References

Details

Attachments

(1 file)

We need to make sure all of the packaging changes that are being made for v2 signatures work with l10n repacks. Spohl has been pushing his patches for this to Oak, so we should enable them there.
Attachment #8473009 - Flags: review?(mshal)
Comment on attachment 8473009 [details] [diff] [review]
enable l10n for mac only

>diff --git a/mozilla/project_branches.py b/mozilla/project_branches.py
>--- a/mozilla/project_branches.py
>+++ b/mozilla/project_branches.py
>@@ -229,6 +229,13 @@ PROJECT_BRANCHES = {
>                 'nightly_signing_servers': 'nightly-signing',
>             },
>         },
>+        # OS X l10n repacks temporarily enabled for bug 1053797
>+        'enable_l10n': True,
>+        'enable_l10n_onchange': False,
>+        'l10n_platforms': ['macosx64'],

So this is specific to macosx64? Or did you want 'macosx' as well?

>+        'l10n_tree': 'fxcentral',
>+        'l10n_repo_path': 'l10n-central',
>+        'enUS_binaryURL': '/nightly/latest-oak',

It looks like the values for enUS_binaryURL in mozilla/config.py all have GLOBAL_VARS['download_base_url'] as a prefix. Do we need that here too or does that get added automatically elsewhere?
Attachment #8473009 - Flags: review?(mshal) → review+
(In reply to Michael Shal [:mshal] from comment #2)
> Comment on attachment 8473009 [details] [diff] [review]
> enable l10n for mac only
> 
> >diff --git a/mozilla/project_branches.py b/mozilla/project_branches.py
> >--- a/mozilla/project_branches.py
> >+++ b/mozilla/project_branches.py
> >@@ -229,6 +229,13 @@ PROJECT_BRANCHES = {
> >                 'nightly_signing_servers': 'nightly-signing',
> >             },
> >         },
> >+        # OS X l10n repacks temporarily enabled for bug 1053797
> >+        'enable_l10n': True,
> >+        'enable_l10n_onchange': False,
> >+        'l10n_platforms': ['macosx64'],
> 
> So this is specific to macosx64? Or did you want 'macosx' as well?

"macosx64" is the platform name for our opt builds. It's confusing, I know - this is a historical artifact.

> >+        'l10n_tree': 'fxcentral',
> >+        'l10n_repo_path': 'l10n-central',
> >+        'enUS_binaryURL': '/nightly/latest-oak',
> 
> It looks like the values for enUS_binaryURL in mozilla/config.py all have
> GLOBAL_VARS['download_base_url'] as a prefix. Do we need that here too or
> does that get added automatically elsewhere?

The latter, and also confusing: https://github.com/mozilla/build-buildbot-configs/blob/master/mozilla/config.py#L2547
Attachment #8473009 - Flags: checked-in+
This went to production yesterday.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.