1053889 - java.lang.NullPointerException in GeckoMediaPlayerManager @ at org.mozilla.gecko.ChromeCast.toJSON(ChromeCast.java:159)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Screencasting, defect)

Description

[Aaron Train [:aaronmt]]

E/GeckoMediaPlayerManager( 9369): Couldn't create JSON for display
E/GeckoMediaPlayerManager( 9369): java.lang.NullPointerException
E/GeckoMediaPlayerManager( 9369):       at org.mozilla.gecko.ChromeCast.toJSON(ChromeCast.java:159)
E/GeckoMediaPlayerManager( 9369):       at org.mozilla.gecko.MediaPlayerManager.handleMessage(MediaPlayerManager.java:130)
E/GeckoMediaPlayerManager( 9369):       at org.mozilla.gecko.EventDispatcher.dispatchEvent(EventDispatcher.java:168)
E/GeckoMediaPlayerManager( 9369):       at org.mozilla.gecko.GeckoAppShell.handleGeckoMessage(GeckoAppShell.java:2290)
E/GeckoMediaPlayerManager( 9369):       at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
E/GeckoMediaPlayerManager( 9369):       at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
E/GeckoMediaPlayerManager( 9369):       at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
E/GeckoMediaPlayerManager( 9369):       at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:360)
E/GeckoMediaPlayerManager( 9369):       at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:186)

I keep seeing this on Nightly (08/14) while just browsing around.

--
Nightly (08/14)
LG Nexus 5 (Android 4.4.4)

Comment 1

[Aaron Train [:aaronmt]]

Also see this when actually casting

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch

This handles CastDevice.getFromBundle(route.getExtras()); returning null. Best guess, that's what's happening here. If it does, we remove the device from our device list.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

I assume this is required on Fx33? Uplift ASAP.

Comment 4

[Wesley Johnston (:wesj)]

Comment on attachment 8477645 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: chromecast code
[User impact if declined]: Crash using chromecast
[Describe test coverage new/current, TBPL]: working on it.
[Risks and why]: low risk. Mostly a null check. Worst case, we will remove the device and you won't be able to cast to it until you restart. Thats better than a crash IMO.
[String/UUID change made/needed]: none.

Comment 5

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/e12e303547c0

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e12e303547c0

Comment 7

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b09553fc5f33