java.lang.NullPointerException in GeckoMediaPlayerManager @ at org.mozilla.gecko.ChromeCast.toJSON(ChromeCast.java:159)

RESOLVED FIXED in Firefox 33

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: aaronmt, Assigned: wesj)

Tracking

34 Branch
Firefox 34
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox33 fixed, firefox34 fixed)

Details

Attachments

(1 attachment)

E/GeckoMediaPlayerManager( 9369): Couldn't create JSON for display
E/GeckoMediaPlayerManager( 9369): java.lang.NullPointerException
E/GeckoMediaPlayerManager( 9369):       at org.mozilla.gecko.ChromeCast.toJSON(ChromeCast.java:159)
E/GeckoMediaPlayerManager( 9369):       at org.mozilla.gecko.MediaPlayerManager.handleMessage(MediaPlayerManager.java:130)
E/GeckoMediaPlayerManager( 9369):       at org.mozilla.gecko.EventDispatcher.dispatchEvent(EventDispatcher.java:168)
E/GeckoMediaPlayerManager( 9369):       at org.mozilla.gecko.GeckoAppShell.handleGeckoMessage(GeckoAppShell.java:2290)
E/GeckoMediaPlayerManager( 9369):       at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
E/GeckoMediaPlayerManager( 9369):       at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
E/GeckoMediaPlayerManager( 9369):       at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
E/GeckoMediaPlayerManager( 9369):       at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:360)
E/GeckoMediaPlayerManager( 9369):       at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:186)

I keep seeing this on Nightly (08/14) while just browsing around.

--
Nightly (08/14)
LG Nexus 5 (Android 4.4.4)
Also see this when actually casting
Posted patch PatchSplinter Review
This handles CastDevice.getFromBundle(route.getExtras()); returning null. Best guess, that's what's happening here. If it does, we remove the device from our device list.
Attachment #8477645 - Flags: review?(mark.finkle)
Attachment #8477645 - Flags: review?(mark.finkle) → review+
I assume this is required on Fx33? Uplift ASAP.
Assignee: nobody → wjohnston
Comment on attachment 8477645 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: chromecast code
[User impact if declined]: Crash using chromecast
[Describe test coverage new/current, TBPL]: working on it.
[Risks and why]: low risk. Mostly a null check. Worst case, we will remove the device and you won't be able to cast to it until you restart. Thats better than a crash IMO.
[String/UUID change made/needed]: none.
Attachment #8477645 - Flags: approval-mozilla-aurora?
Blocks: 901803
https://hg.mozilla.org/mozilla-central/rev/e12e303547c0
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Attachment #8477645 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.