Closed
Bug 1053889
Opened 10 years ago
Closed 10 years ago
java.lang.NullPointerException in GeckoMediaPlayerManager @ at org.mozilla.gecko.ChromeCast.toJSON(ChromeCast.java:159)
Categories
(Firefox for Android Graveyard :: Screencasting, defect)
Tracking
(firefox33 fixed, firefox34 fixed)
RESOLVED
FIXED
Firefox 34
People
(Reporter: aaronmt, Assigned: wesj)
References
Details
Attachments
(1 file)
4.12 KB,
patch
|
mfinkle
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
E/GeckoMediaPlayerManager( 9369): Couldn't create JSON for display E/GeckoMediaPlayerManager( 9369): java.lang.NullPointerException E/GeckoMediaPlayerManager( 9369): at org.mozilla.gecko.ChromeCast.toJSON(ChromeCast.java:159) E/GeckoMediaPlayerManager( 9369): at org.mozilla.gecko.MediaPlayerManager.handleMessage(MediaPlayerManager.java:130) E/GeckoMediaPlayerManager( 9369): at org.mozilla.gecko.EventDispatcher.dispatchEvent(EventDispatcher.java:168) E/GeckoMediaPlayerManager( 9369): at org.mozilla.gecko.GeckoAppShell.handleGeckoMessage(GeckoAppShell.java:2290) E/GeckoMediaPlayerManager( 9369): at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method) E/GeckoMediaPlayerManager( 9369): at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method) E/GeckoMediaPlayerManager( 9369): at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method) E/GeckoMediaPlayerManager( 9369): at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:360) E/GeckoMediaPlayerManager( 9369): at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:186) I keep seeing this on Nightly (08/14) while just browsing around. -- Nightly (08/14) LG Nexus 5 (Android 4.4.4)
Reporter | ||
Comment 1•10 years ago
|
||
Also see this when actually casting
Assignee | ||
Comment 2•10 years ago
|
||
This handles CastDevice.getFromBundle(route.getExtras()); returning null. Best guess, that's what's happening here. If it does, we remove the device from our device list.
Attachment #8477645 -
Flags: review?(mark.finkle)
Updated•10 years ago
|
Attachment #8477645 -
Flags: review?(mark.finkle) → review+
Comment 3•10 years ago
|
||
I assume this is required on Fx33? Uplift ASAP.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → wjohnston
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8477645 [details] [diff] [review] Patch Approval Request Comment [Feature/regressing bug #]: chromecast code [User impact if declined]: Crash using chromecast [Describe test coverage new/current, TBPL]: working on it. [Risks and why]: low risk. Mostly a null check. Worst case, we will remove the device and you won't be able to cast to it until you restart. Thats better than a crash IMO. [String/UUID change made/needed]: none.
Attachment #8477645 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/e12e303547c0
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e12e303547c0
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Updated•10 years ago
|
status-firefox33:
--- → affected
status-firefox34:
--- → fixed
Updated•10 years ago
|
Attachment #8477645 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/b09553fc5f33
Updated•10 years ago
|
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•