1053948 - System JS : WARNING resource://gre/modules/FxAccounts.jsm:64 - assignment to undeclared variable AccountState

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Daniel Holbert [:dholbert]]

Noticed this go by in my terminal output, when starting my debug-build: 
{
System JS : WARNING resource://gre/modules/FxAccounts.jsm:64 - assignment to undeclared variable AccountState
}

This is from this code:
> 64 AccountState = function(fxaInternal) {
> 65   this.fxaInternal = fxaInternal;
> 66 };
http://mxr.mozilla.org/mozilla-central/source/services/fxaccounts/FxAccounts.jsm?rev=746fb5986153#64

I suspect this just needs a "let" on line 64, to declare AccountState.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0001-Bug-1053948-declare-AccountState-in-fxAccounts.-r-ck.patch

Nice catch - thanks!  Trivial patch attached.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 8474287 [details] [diff] [review]
0001-Bug-1053948-declare-AccountState-in-fxAccounts.-r-ck.patch

Welcome back, Mark :)

Comment 3

[Chris Karlof [:ckarlof]]

God yes, welcome back!

Comment 4

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/fx-team/rev/f8bb07dbe641

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f8bb07dbe641