[B2G][Flame][Settings][App permissions] There is no space below the Loop 'Uninstall app' button

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
--
minor
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: rpribble, Assigned: arnau)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(b2g-v2.0 affected, b2g-v2.1 affected)

Details

(Whiteboard: [platform][not blocking][2.0-exploratory][tef-triage])

Attachments

(3 attachments, 2 obsolete attachments)

(Reporter)

Description

4 years ago
Created attachment 8473174 [details]
Screenshots.jpg

Description:
The Loop app permissions page is lacking padding below the 'Uninstall app' button. In other areas of the phone with the same layout, spacing below the button is seen (deleting a contact used as example in the screenshot attached).

Prerequisites:
1) Set DUT language to Serbian Latin (srpski).
2) Have Loop installed on DUT

Repro Steps:
1) Update a Flame device to BuildID: 20140811000210
2) Settings > App permissions > Loop
3) Scroll all the way down
  
Actual:
There is no padding below the Loop 'Uninstall app' button.
  
Expected: 
No elements appear too close to the edge of the screen.
  
Environmental Variables:
Device: Flame 2.0
BuildID: 20140811000210
Gaia: de28796a8956a48bb98ca67df6a33e0622d642d1
Gecko: 5256345f62bd
Version: 32.0 (2.0)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
  
Keywords: margins, spacing, too close, too low
  
Repro frequency: 100%
See attached: Screenshot, logcat
Localization team can't do anything here.

Delphine please assign someone else.
Thanks!
Flags: needinfo?(lebedel.delphine)
(Reporter)

Comment 2

4 years ago
This issue also occurs on the Flame v2.1 (319MB), Buri v2.1, Flame v2.0 (512MB), and Buri v2.0.

Device: Flame Master (319MB)
Build ID: 20140813040202
Gaia: 9f35fca9d818b26c06aa6b7e5c0bef25886f8f20
Gecko: 7fc96293ada8
Version: 34.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.0 (512MB)
BuildID: 20140811000210
Gaia: de28796a8956a48bb98ca67df6a33e0622d642d1
Gecko: 5256345f62bd
Version: 32.0 (2.0)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Device: Buri Master
Build ID: 20140814013001
Gaia: 5e074831f9ddacdf6f622a6dffaecb626f740be8
Gecko: 5299864050ee
Version: 34.0a1 (Master)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Buri 2.0
Build ID: 20140814000201
Gaia: 8b1b64ca3347e015d7a57df6d053f95cd26046ca
Gecko: 2f288e8aea09
Version: 32.0 (2.0)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

There is no padding below the Loop 'Uninstall app' button

---------------------------------------

Loop is not available on the v1.4 branch.

---------------------------------------
QA Whiteboard: [QAnalyst-Triage?]
status-b2g-v2.1: --- → affected
Flags: needinfo?(ktucker)
(Reporter)

Comment 3

4 years ago
My fault, logged it as localization incorrectly. Sorry about that Vanja, changing to Firefox OS now.
Component: sr / Serbian → Gaia::Settings
Flags: needinfo?(lebedel.delphine)
Product: Mozilla Localizations → Firefox OS
Component: Gaia::Settings → Layout
Flags: needinfo?(ktucker)
Product: Firefox OS → Core
(Reporter)

Comment 4

4 years ago
This issue occurs regardless of the language of the DUT.

I do not know if this is a Loop specific bug, as Loop is the only app that I can find that has a scrollable permissions page.  All other app permissions pages are short with no scrolling required.
Blocks: 1036490
Flags: needinfo?(ktucker)
Summary: [B2G][Flame][Settings][App permissions] Serbian Latin: There is no space below the Loop 'Uninstall app' button → [B2G][Flame][Settings][App permissions] There is no space below the Loop 'Uninstall app' button
Without anything pointing at layout, this should start as a bug in the relevant app.
Component: Layout → Gaia::Settings
Product: Core → Firefox OS
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
(In reply to Rachel Pribble (rpribble@qanalydocs.com) from comment #4)
> I do not know if this is a Loop specific bug, as Loop is the only app that I
> can find that has a scrollable permissions page.  All other app permissions
> pages are short with no scrolling required.

(side note: seems like it'd be worth it for us to have a dummy app that requests all known permissions, for testing scenarios like this.)

Updated

4 years ago
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage+][lead-review+]
This is not a loop issue but a gaia one (settings app), marking it as non-blocking as the app can still be uninstalled.
Whiteboard: [2.0-exploratory] → [platform][not blocking]

Updated

4 years ago
Whiteboard: [platform][not blocking] → [platform][not blocking][2.0-exploratory]
Whiteboard: [platform][not blocking][2.0-exploratory] → [platform][not blocking][2.0-exploratory][tef-triage]
Severity: normal → minor
Arnau, can you have a look at it? let's try to fix it, at least for 2.2 version
Flags: needinfo?(rnowmrch)
Assignee: nobody → rnowmrch
Flags: needinfo?(rnowmrch)
Created attachment 8517406 [details]
after_patch.png

Hey Przemek could you please validate that screen? AFAIK we should not use a red button, as we have a modal screen triggered which will prevent us from removing the app in case this was an unwanted action.
Attachment #8517406 - Flags: ui-review?(pabratowski)
Comment on attachment 8517406 [details]
after_patch.png

The spacing is better not but I still think we should use a rounded and red button here. Also I don't think we need to use a sub-header saying 'Uninstall App' right above a button that says the exact same thing. Please remove the sub-header and use a simple divider line just like the delete contacts example shown in the original screenshot for this bug.

Thank you
Attachment #8517406 - Flags: ui-review?(pabratowski) → ui-review-
Created attachment 8517482 [details]
after_patch.png
Attachment #8517482 - Flags: ui-review?(pabratowski)
Attachment #8517406 - Attachment is obsolete: true
Attachment #8517482 - Attachment is obsolete: true
Attachment #8517482 - Flags: ui-review?(pabratowski)
Created attachment 8517498 [details]
after_patch.png
Attachment #8517498 - Flags: ui-review?(pabratowski)
Comment on attachment 8517498 [details]
after_patch.png

Thank you :)
Attachment #8517498 - Flags: ui-review?(pabratowski) → ui-review+
Attachment #8517404 - Flags: review?(arthur.chen)
Comment on attachment 8517404 [details] [review]
patch in github

r=me with the comment addressed, thanks.
Attachment #8517404 - Flags: review?(arthur.chen) → review+
merged: https://github.com/mozilla-b2g/gaia/commit/c5bad6d78c5fe168e3bb894fc5cb70902c9b19b1
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.