1053968 - Clean up mozL10n API use in SMS

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

Now, with majority of mozL10n.get cleaned up in bug 1040271, let's tackle mozL10n.translate and mozL10n.localize.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: pull request

Julien, can you take a look at this patch?

All the changes are pretty trivial, but I struggle to update 4 tests in sms/test/unit/shared_components_test.js because I quite frankly don't understand them :(

Can you help me update those four? Once I get the test passing, I'll ask for review.

Comment 2

[Julien Wajsberg [:julienw]]

Comment on attachment 8473914 [details] [review]
pull request

As I'm going in holidays soon, redirecting the feedback request to Oleg who'll check everything works fine with the patch :)

Comment 3

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8473914 [details] [review]
pull request

Looks good! Just few questions, some indentation and unit tests nits left on GitHub.

Thanks!

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8473914 [details] [review]
pull request

Thanks for feedback! I updated the patch to address your comments.

Comment 5

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8473914 [details] [review]
pull request

r=me with a few tiny nits!

Thanks!

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Commit: https://github.com/mozilla-b2g/gaia/commit/684ebe380d1d17cd4126aa45c451046bdda337c2
Merge: https://github.com/mozilla-b2g/gaia/commit/caa2d0e2949ef76c0a3938516d1b0631028010ba

Thanks Oleg!