Closed Bug 1053968 Opened 6 years ago Closed 6 years ago

Clean up mozL10n API use in SMS

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

x86
All
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: zbraniecki, Assigned: zbraniecki)

References

()

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
azasypkin
: review+
azasypkin
: feedback+
Details | Review
Now, with majority of mozL10n.get cleaned up in bug 1040271, let's tackle mozL10n.translate and mozL10n.localize.
Attached file pull request
Julien, can you take a look at this patch?

All the changes are pretty trivial, but I struggle to update 4 tests in sms/test/unit/shared_components_test.js because I quite frankly don't understand them :(

Can you help me update those four? Once I get the test passing, I'll ask for review.
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Attachment #8473914 - Flags: feedback?(felash)
Comment on attachment 8473914 [details] [review]
pull request

As I'm going in holidays soon, redirecting the feedback request to Oleg who'll check everything works fine with the patch :)
Attachment #8473914 - Flags: feedback?(felash) → feedback?(azasypkin)
Comment on attachment 8473914 [details] [review]
pull request

Looks good! Just few questions, some indentation and unit tests nits left on GitHub.

Thanks!
Attachment #8473914 - Flags: feedback?(azasypkin) → feedback+
Comment on attachment 8473914 [details] [review]
pull request

Thanks for feedback! I updated the patch to address your comments.
Attachment #8473914 - Flags: review?(azasypkin)
Comment on attachment 8473914 [details] [review]
pull request

r=me with a few tiny nits!

Thanks!
Attachment #8473914 - Flags: review?(azasypkin) → review+
You need to log in before you can comment on or make changes to this bug.